content/browser/renderer_host/compositor_impl_android.h - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/compositor_impl_android.h

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/renderer_host/compositor_impl_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/compositor_impl_android.h

diff --git a/content/browser/renderer_host/compositor_impl_android.h b/content/browser/renderer_host/compositor_impl_android.h

index 3bc86da515995d44d13dfcdcbd14ba9c1bab4db2..e77dd9126a2a37e1d308a920ca18a33d785daa83 100644

--- a/content/browser/renderer_host/compositor_impl_android.h

+++ b/content/browser/renderer_host/compositor_impl_android.h

@@ -64,7 +64,7 @@ class CONTENT_EXPORT CompositorImpl

static bool IsInitialized();

static cc::SurfaceManager* GetSurfaceManager();

- static std::unique_ptr<cc::SurfaceIdAllocator> CreateSurfaceIdAllocator();

+ static uint32_t AllocateSurfaceClientId();

static scoped_refptr<cc::VulkanInProcessContextProvider>

SharedVulkanContextProviderAndroid();