ash/sysui/stub_context_factory.cc - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/sysui/stub_context_factory.cc

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/sysui/stub_context_factory.cc

diff --git a/ash/sysui/stub_context_factory.cc b/ash/sysui/stub_context_factory.cc

index ce7af105a52e917fadc38c0145c89db77e337821..44f7512c932555195dc1bf3aeff06490c73b4a8f 100644

--- a/ash/sysui/stub_context_factory.cc

+++ b/ash/sysui/stub_context_factory.cc

@@ -71,10 +71,8 @@ cc::TaskGraphRunner* StubContextFactory::GetTaskGraphRunner() {

return task_graph_runner_.get();

}

-std::unique_ptr<cc::SurfaceIdAllocator>

-StubContextFactory::CreateSurfaceIdAllocator() {

- return base::WrapUnique(

- new cc::SurfaceIdAllocator(next_surface_id_namespace_++));

+uint32_t StubContextFactory::AllocateSurfaceClientId() {

+ return next_surface_id_namespace_++;

}

cc::SurfaceManager* StubContextFactory::GetSurfaceManager() {

« no previous file with comments | « ash/sysui/stub_context_factory.h ('k') | cc/surfaces/display_unittest.cc » ('j') | no next file with comments »