android_webview/browser/surfaces_instance.h - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/surfaces_instance.h

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/surfaces_instance.h

diff --git a/android_webview/browser/surfaces_instance.h b/android_webview/browser/surfaces_instance.h

index e92f15b87ab6a0a990ec177afb9024e3a5b0241c..eb01f71402add51d94beeb9907f7c5313efc5758 100644

--- a/android_webview/browser/surfaces_instance.h

+++ b/android_webview/browser/surfaces_instance.h

@@ -38,7 +38,7 @@ class SurfacesInstance : public base::RefCounted<SurfacesInstance>,

public:

static scoped_refptr<SurfacesInstance> GetOrCreateInstance();

- std::unique_ptr<cc::SurfaceIdAllocator> CreateSurfaceIdAllocator();

+ uint32_t AllocateSurfaceClientId();

cc::SurfaceManager* GetSurfaceManager();

void SetBackingFrameBufferObject(int framebuffer_binding_ext);

« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | android_webview/browser/surfaces_instance.cc » ('j') | no next file with comments »