Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Side by Side Diff: content/browser/compositor/surface_utils.cc

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/compositor/surface_utils.h" 5 #include "content/browser/compositor/surface_utils.h"
6 6
7 #include "base/callback_helpers.h" 7 #include "base/callback_helpers.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "cc/output/copy_output_result.h" 10 #include "cc/output/copy_output_result.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 SkPaint paint; 151 SkPaint paint;
152 paint.setColorFilter(SkLumaColorFilter::Make()); 152 paint.setColorFilter(SkLumaColorFilter::Make());
153 canvas.drawBitmap(scaled_bitmap, SkIntToScalar(0), SkIntToScalar(0), &paint); 153 canvas.drawBitmap(scaled_bitmap, SkIntToScalar(0), SkIntToScalar(0), &paint);
154 callback.Run(grayscale_bitmap, content::READBACK_SUCCESS); 154 callback.Run(grayscale_bitmap, content::READBACK_SUCCESS);
155 } 155 }
156 156
157 } // namespace 157 } // namespace
158 158
159 namespace content { 159 namespace content {
160 160
161 std::unique_ptr<cc::SurfaceIdAllocator> CreateSurfaceIdAllocator() { 161 uint32_t AllocateSurfaceClientId() {
162 #if defined(OS_ANDROID) 162 #if defined(OS_ANDROID)
163 return CompositorImpl::CreateSurfaceIdAllocator(); 163 return CompositorImpl::AllocateSurfaceClientId();
164 #else 164 #else
165 ImageTransportFactory* factory = ImageTransportFactory::GetInstance(); 165 ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
166 return factory->GetContextFactory()->CreateSurfaceIdAllocator(); 166 return factory->GetContextFactory()->AllocateSurfaceClientId();
167 #endif 167 #endif
168 } 168 }
169 169
170 cc::SurfaceManager* GetSurfaceManager() { 170 cc::SurfaceManager* GetSurfaceManager() {
171 #if defined(OS_ANDROID) 171 #if defined(OS_ANDROID)
172 return CompositorImpl::GetSurfaceManager(); 172 return CompositorImpl::GetSurfaceManager();
173 #else 173 #else
174 ImageTransportFactory* factory = ImageTransportFactory::GetInstance(); 174 ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
175 if (factory == NULL) 175 if (factory == NULL)
176 return nullptr; 176 return nullptr;
(...skipping 24 matching lines...) Expand all
201 return; 201 return;
202 } 202 }
203 203
204 DCHECK(result->HasBitmap()); 204 DCHECK(result->HasBitmap());
205 // Software path 205 // Software path
206 PrepareBitmapCopyOutputResult(output_size_in_pixel, color_type, callback, 206 PrepareBitmapCopyOutputResult(output_size_in_pixel, color_type, callback,
207 std::move(result)); 207 std::move(result));
208 } 208 }
209 209
210 } // namespace content 210 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/compositor/surface_utils.h ('k') | content/browser/frame_host/render_widget_host_view_child_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698