Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2166383002: [FRE] Disable swipe gesture and smoothly scroll effect (Closed)

Created:
4 years, 5 months ago by gogerald1
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable swipe gesture and smoothly scroll Smoothly scroll effect also triggers TalkBack read previous screen after navigate to new screen. BUG=602373, 628255 Committed: https://crrev.com/77ad42cf03108d58527f944d7ea3be3bf9e19742 Cr-Commit-Position: refs/heads/master@{#407149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 9 chunks +8 lines, -10 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunViewPager.java View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
gogerald1
Hi, PTAL,
4 years, 5 months ago (2016-07-21 15:29:00 UTC) #8
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-22 08:21:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166383002/1
4 years, 5 months ago (2016-07-22 13:56:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 14:00:28 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 14:02:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77ad42cf03108d58527f944d7ea3be3bf9e19742
Cr-Commit-Position: refs/heads/master@{#407149}

Powered by Google App Engine
This is Rietveld 408576698