Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2166373002:
[system-health] Re-enable stories failing smoke test due to CSSImageValue issue (Closed)
|
Created:
4 years, 5 months ago by petrcermak Modified:
4 years, 5 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[system-health] Re-enable stories failing smoke test due to CSSImageValue issue
The problem has been fixed: https://codereview.chromium.org/2168903002/
BUG=630215
Committed: https://crrev.com/ec705c571737dd02f19e14320979ee531fa24382
Cr-Commit-Position: refs/heads/master@{#406866}
Patch Set 1 #
Messages
Total messages: 15 (9 generated)
Description was changed from ========== [system-health] Re-enable stories failing smoke test due to CSSFontFaceSrcValue issue The problem has been fixed: https://codereview.chromium.org/2168903002/ BUG=630215 ========== to ========== [system-health] Re-enable stories failing smoke test due to CSSImageValue issue The problem has been fixed: https://codereview.chromium.org/2168903002/ BUG=630215 ==========
petrcermak@chromium.org changed reviewers: + nednguyen@google.com
PTAL. Thanks, Petr
The CQ bit was checked by petrcermak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [system-health] Re-enable stories failing smoke test due to CSSImageValue issue The problem has been fixed: https://codereview.chromium.org/2168903002/ BUG=630215 ========== to ========== [system-health] Re-enable stories failing smoke test due to CSSImageValue issue The problem has been fixed: https://codereview.chromium.org/2168903002/ BUG=630215 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [system-health] Re-enable stories failing smoke test due to CSSImageValue issue The problem has been fixed: https://codereview.chromium.org/2168903002/ BUG=630215 ========== to ========== [system-health] Re-enable stories failing smoke test due to CSSImageValue issue The problem has been fixed: https://codereview.chromium.org/2168903002/ BUG=630215 Committed: https://crrev.com/ec705c571737dd02f19e14320979ee531fa24382 Cr-Commit-Position: refs/heads/master@{#406866} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ec705c571737dd02f19e14320979ee531fa24382 Cr-Commit-Position: refs/heads/master@{#406866}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2178533002/ by mpearson@chromium.org. The reason for reverting is: See bug 630663. Causes regular failures in one nytimes smoke_test --- [1/1] benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:news:nytimes failed unexpectedly 256.4172s: [ RUN ] browse:news:nytimes Traceback (most recent call last): File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 85, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 319, in RunStory self._current_page.Run(self) File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/page/__init__.py", line 99, in Run self.RunPageInteractions(action_runner) File "/b/swarm_slave/w/irtOOh2q/tools/perf/page_sets/system_health/system_health_story.py", line 79, in RunPageInteractions self._DidLoadDocument(action_runner) File "/b/swarm_slave/w/irtOOh2q/tools/perf/page_sets/system_health/browsing_stories.py", line 61, in _DidLoadDocument self._ReadNewsItem(action_runner) File "/b/swarm_slave/w/irtOOh2q/tools/perf/page_sets/system_health/browsing_stories.py", line 66, in _ReadNewsItem action_runner.tab.WaitForDocumentReadyStateToBeComplete() File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 70, in WaitForDocumentReadyStateToBeComplete 'document.readyState == "complete"', timeout) File "/b/swarm_slave/w/irtOOh2q/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 136, in WaitForJavaScriptExpression e.message + '\n' + debug_message) TimeoutException: Timed out while waiting 90s for IsJavaScriptExpressionTrue. Console output: (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation %cCONTINUE (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation: %cCONTINUE %ccreative ids 48524723 (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation: INIT -- (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation: NOBID 241ms (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: anx-mediation: CONTINUE 241ms (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: console.groupEnd (log) http://acdn.adnxs.com/mediation/mediation.js?cb=1469120806459:1: console.groupEnd [ FAILED ] browse:news:nytimes (248456 ms) ---. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
