Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2166353002: Prevent icons in the detail view rendered outside the file name column. (Closed)

Created:
4 years, 5 months ago by yamaguchi
Modified:
4 years, 5 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent icons in the detail view from getting outside the file name column. .detail-checkmark creates a new containing block by position:absolute so that it is always clickable, but the thumbnail icons should not do that. BUG=630236 TEST=manual Committed: https://crrev.com/8a0fee87966c21049e1ad1781df3689522f4f5ee Cr-Commit-Position: refs/heads/master@{#407103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
fukino
lgtm. Thank you!
4 years, 5 months ago (2016-07-22 06:37:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166353002/1
4 years, 5 months ago (2016-07-22 08:07:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 08:50:26 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 08:53:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a0fee87966c21049e1ad1781df3689522f4f5ee
Cr-Commit-Position: refs/heads/master@{#407103}

Powered by Google App Engine
This is Rietveld 408576698