Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216633006: [Ozone] Add default case otherwise compiler complains about missing return (Closed)

Created:
6 years, 8 months ago by dnicoara
Modified:
6 years, 8 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

[Ozone] Add default case otherwise compiler complains about missing return TBR=danakj@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261397

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/compositor/overlay_candidate_validator_ozone.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dnicoara
PTAL
6 years, 8 months ago (2014-04-03 14:23:51 UTC) #1
danakj
https://codereview.chromium.org/216633006/diff/1/content/browser/compositor/overlay_candidate_validator_ozone.cc File content/browser/compositor/overlay_candidate_validator_ozone.cc (right): https://codereview.chromium.org/216633006/diff/1/content/browser/compositor/overlay_candidate_validator_ozone.cc#newcode21 content/browser/compositor/overlay_candidate_validator_ozone.cc:21: default: instead of default, which will take away compile-time ...
6 years, 8 months ago (2014-04-03 14:25:34 UTC) #2
dnicoara
https://codereview.chromium.org/216633006/diff/1/content/browser/compositor/overlay_candidate_validator_ozone.cc File content/browser/compositor/overlay_candidate_validator_ozone.cc (right): https://codereview.chromium.org/216633006/diff/1/content/browser/compositor/overlay_candidate_validator_ozone.cc#newcode21 content/browser/compositor/overlay_candidate_validator_ozone.cc:21: default: On 2014/04/03 14:25:34, danakj wrote: > instead of ...
6 years, 8 months ago (2014-04-03 14:34:34 UTC) #3
alexst (slow to review)
lgtm, thank you.
6 years, 8 months ago (2014-04-03 14:37:13 UTC) #4
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-03 14:42:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/216633006/40001
6 years, 8 months ago (2014-04-03 14:44:18 UTC) #6
danakj
LGTM2
6 years, 8 months ago (2014-04-03 14:46:15 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:02:20 UTC) #8
Message was sent while issue was closed. 
Change committed as 261397

Powered by Google App Engine
This is Rietveld 408576698