Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2336)

Issue 2166263002: MD History: Make the forward slash key to rely on focused only (Closed)

Created:
4 years, 5 months ago by lshang
Modified:
4 years, 5 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG=630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/be2ed6853f0834e6396188ad110ee1eecdef36f6 Cr-Commit-Position: refs/heads/master@{#407020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/resources/md_history/app.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
lshang
PTAL thanks!
4 years, 5 months ago (2016-07-22 00:00:39 UTC) #5
tsergeant
lgtm
4 years, 5 months ago (2016-07-22 00:23:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166263002/1
4 years, 5 months ago (2016-07-22 03:00:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:25:04 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:29:33 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be2ed6853f0834e6396188ad110ee1eecdef36f6
Cr-Commit-Position: refs/heads/master@{#407020}

Powered by Google App Engine
This is Rietveld 408576698