|
|
Created:
4 years, 5 months ago by lshang Modified:
4 years, 5 months ago Reviewers:
tsergeant CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD History: Make the forward slash key to rely on focused only
There are cases about the search field where:
- it is showing and focused, which means user is inside the field and forward
slash key should be regarded as input.
- it is not showing and focused, in which case the forward slash key should be
run shortcut command.
- it is showing, but not focused, when there are some contents in the field and
it loses focus, in this case forward slash key should be shortcut.
- it is not showing, but focused, when user uses Tab to focus on the field,
forward slash key should be input.
Considering all these cases, the forward slash key shortcut should just rely on
focused only.
BUG=630175
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/be2ed6853f0834e6396188ad110ee1eecdef36f6
Cr-Commit-Position: refs/heads/master@{#407020}
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
Description was changed from ========== MD History: Make the forward slash key to rely on focused only BUG= ========== to ========== MD History: Make the forward slash key to rely on focused only BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD History: Make the forward slash key to rely on focused only BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG=630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG=630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG=630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lshang@chromium.org changed reviewers: + tsergeant@chromium.org
PTAL thanks!
lgtm
The CQ bit was checked by lshang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lshang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG=630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG=630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG=630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD History: Make the forward slash key to rely on focused only There are cases about the search field where: - it is showing and focused, which means user is inside the field and forward slash key should be regarded as input. - it is not showing and focused, in which case the forward slash key should be run shortcut command. - it is showing, but not focused, when there are some contents in the field and it loses focus, in this case forward slash key should be shortcut. - it is not showing, but focused, when user uses Tab to focus on the field, forward slash key should be input. Considering all these cases, the forward slash key shortcut should just rely on focused only. BUG=630175 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/be2ed6853f0834e6396188ad110ee1eecdef36f6 Cr-Commit-Position: refs/heads/master@{#407020} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/be2ed6853f0834e6396188ad110ee1eecdef36f6 Cr-Commit-Position: refs/heads/master@{#407020} |