Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

Issue 2166213002: Fire attributeChangedCallback on style changes for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dominicc review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp
index 17467d0b6e240997dcd0094d6d4fe180a48a455c..0f50fdf2867ffcc1c66ddb43cc3da1a52154f4e4 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp
@@ -231,6 +231,12 @@ public:
{
}
+ TestCustomElementDefinition(const CustomElementDescriptor& descriptor,
+ const HashSet<AtomicString>& observedAttributes)
+ : CustomElementDefinition(descriptor, observedAttributes)
+ {
+ }
+
~TestCustomElementDefinition() override = default;
ScriptValue getConstructorForScript() override
@@ -265,11 +271,12 @@ class LogUpgradeDefinition : public TestCustomElementDefinition {
WTF_MAKE_NONCOPYABLE(LogUpgradeDefinition);
public:
LogUpgradeDefinition(const CustomElementDescriptor& descriptor)
- : TestCustomElementDefinition(descriptor)
+ : TestCustomElementDefinition(descriptor, {
+ "attr1",
+ "attr2",
+ HTMLNames::contenteditableAttr.localName(),
+ })
{
- m_observedAttributes.add("attr1");
- m_observedAttributes.add("attr2");
- m_observedAttributes.add(HTMLNames::contenteditableAttr.localName());
}
DEFINE_INLINE_VIRTUAL_TRACE()
« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698