Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2166213002: Fire attributeChangedCallback on style changes for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dominicc review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
index a1db45a656006e5d441650bb343a64453220c122..eead3c526ef6c9cdb136eb53e4e43876400735aa 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
@@ -56,7 +56,8 @@ public:
virtual bool hasConnectedCallback() const = 0;
virtual bool hasDisconnectedCallback() const = 0;
- bool hasAttributeChangedCallback(const QualifiedName&);
+ bool hasAttributeChangedCallback(const QualifiedName&) const;
+ bool hasStyleAttributeChangedCallback() const;
virtual void runConnectedCallback(Element*) = 0;
virtual void runDisconnectedCallback(Element*) = 0;
@@ -74,11 +75,11 @@ protected:
static void checkConstructorResult(Element*, Document&, const QualifiedName&, ExceptionState&);
- HashSet<AtomicString> m_observedAttributes;
-
private:
const CustomElementDescriptor m_descriptor;
ConstructionStack m_constructionStack;
+ HashSet<AtomicString> m_observedAttributes;
+ bool m_hasStyleAttributeChangedCallback;
void enqueueAttributeChangedCallbackForAllAttributes(Element*);
};

Powered by Google App Engine
This is Rietveld 408576698