third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl - Issue 2166213002: Fire attributeChangedCallback on style changes for Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

Issue 2166213002: Fire attributeChangedCallback on style changes for Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/custom-elements/spec/callback.html ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp ('k') | third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp » ('j') | third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

diff --git a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

index 9386183af39775a2a16599416b082fe8bb705c5f..5aeff6beab15a77f2525fd6b94a334374d336a7c 100644

--- a/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

+++ b/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl

@@ -24,17 +24,17 @@

DependentLifetime,

SetWrapperReferenceTo(CSSRule parentRule),

] interface CSSStyleDeclaration {

- [RaisesException=Setter] attribute DOMString cssText;

+ [CEReactions, RaisesException=Setter] attribute DOMString cssText;

readonly attribute unsigned long length;

getter DOMString item(unsigned long index);

DOMString getPropertyValue(DOMString property);

DOMString getPropertyPriority(DOMString property);

// TODO(foolip): The value and priority arguments should have

// [TreatNullAs=EmptyString] and should not be nullable.

- [RaisesException] void setProperty(DOMString property, DOMString? value, optional DOMString? priority = null);

+ [CEReactions, RaisesException] void setProperty(DOMString property, DOMString? value, optional DOMString? priority = null);

// void setPropertyValue(DOMString property, [TreatNullAs=EmptyString] DOMString value);

// void setPropertyPriority(DOMString property, [TreatNullAs=EmptyString] DOMString priority);

- [RaisesException] DOMString removeProperty(DOMString property);

+ [CEReactions, RaisesException] DOMString removeProperty(DOMString property);

readonly attribute CSSRule? parentRule;

[RaisesException=Setter, TreatNullAs=EmptyString] attribute DOMString cssFloat;

dominicc (has gone to gerrit) 2016/07/22 01:14:01 Does this need CEReactions too?

kojii 2016/07/22 04:43:53 Done, missed that, thank you. Added the spec link