Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2166203002: Disable flaky MetricsWebContentsObserverBrowserTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
9 #include "chrome/common/url_constants.h" 9 #include "chrome/common/url_constants.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 29 matching lines...) Expand all
40 embedded_test_server()->GetURL("/title2.html")); 40 embedded_test_server()->GetURL("/title2.html"));
41 41
42 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1); 42 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);
43 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1); 43 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);
44 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); 44 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);
45 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1); 45 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1);
46 histogram_tester_.ExpectTotalCount( 46 histogram_tester_.ExpectTotalCount(
47 internal::kHistogramParseBlockedOnScriptLoad, 1); 47 internal::kHistogramParseBlockedOnScriptLoad, 1);
48 } 48 }
49 49
50 // Flaky in win: crbug.com/630076
50 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, 51 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
51 SamePageNavigation) { 52 DISABLED_SamePageNavigation) {
52 ASSERT_TRUE(embedded_test_server()->Start()); 53 ASSERT_TRUE(embedded_test_server()->Start());
53 54
54 ui_test_utils::NavigateToURL(browser(), 55 ui_test_utils::NavigateToURL(browser(),
55 embedded_test_server()->GetURL("/title1.html")); 56 embedded_test_server()->GetURL("/title1.html"));
56 ui_test_utils::NavigateToURL( 57 ui_test_utils::NavigateToURL(
57 browser(), embedded_test_server()->GetURL("/title1.html#hash")); 58 browser(), embedded_test_server()->GetURL("/title1.html#hash"));
58 ui_test_utils::NavigateToURL(browser(), 59 ui_test_utils::NavigateToURL(browser(),
59 embedded_test_server()->GetURL("/title2.html")); 60 embedded_test_server()->GetURL("/title2.html"));
60 61
61 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1); 62 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);
62 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1); 63 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);
63 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); 64 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);
64 } 65 }
65 66
67 // Flaky in win: crbug.com/630076
66 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, 68 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
67 SameUrlNavigation) { 69 DISABLED_SameUrlNavigation) {
68 ASSERT_TRUE(embedded_test_server()->Start()); 70 ASSERT_TRUE(embedded_test_server()->Start());
69 71
70 ui_test_utils::NavigateToURL(browser(), 72 ui_test_utils::NavigateToURL(browser(),
71 embedded_test_server()->GetURL("/title1.html")); 73 embedded_test_server()->GetURL("/title1.html"));
72 ui_test_utils::NavigateToURL(browser(), 74 ui_test_utils::NavigateToURL(browser(),
73 embedded_test_server()->GetURL("/title1.html")); 75 embedded_test_server()->GetURL("/title1.html"));
74 ui_test_utils::NavigateToURL(browser(), 76 ui_test_utils::NavigateToURL(browser(),
75 embedded_test_server()->GetURL("/title2.html")); 77 embedded_test_server()->GetURL("/title2.html"));
76 78
77 // We expect one histogram sample for each navigation to title1.html. 79 // We expect one histogram sample for each navigation to title1.html.
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 226
225 ui_test_utils::NavigateToURL( 227 ui_test_utils::NavigateToURL(
226 browser(), embedded_test_server()->GetURL( 228 browser(), embedded_test_server()->GetURL(
227 "/page_load_metrics/document_write_no_script.html")); 229 "/page_load_metrics/document_write_no_script.html"));
228 ui_test_utils::NavigateToURL(browser(), 230 ui_test_utils::NavigateToURL(browser(),
229 embedded_test_server()->GetURL("/title2.html")); 231 embedded_test_server()->GetURL("/title2.html"));
230 232
231 histogram_tester_.ExpectTotalCount( 233 histogram_tester_.ExpectTotalCount(
232 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); 234 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
233 } 235 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698