pdf/preview_mode_client.h - Issue 2166193002: Handle ctrl + shift + left click on links in PDF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/preview_mode_client.h

Issue 2166193002: Handle ctrl + shift + left click on links in PDF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle ctrl + shift + left click on links in PDF. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/preview_mode_client.h

diff --git a/pdf/preview_mode_client.h b/pdf/preview_mode_client.h

index 0127db9a3a59d6cdde4615473bdbc5d897f9d14d..6eda5f0d40cf2701a09e083b97fa67415ef930e4 100644

--- a/pdf/preview_mode_client.h

+++ b/pdf/preview_mode_client.h

@@ -33,7 +33,8 @@ class PreviewModeClient : public PDFEngine::Client {

void ScrollToX(int position) override;

void ScrollToY(int position) override;

void ScrollToPage(int page) override;

- void NavigateTo(const std::string& url, bool open_in_new_tab) override;

+ void NavigateTo(const std::string& url,

+ WindowOpenDisposition disposition) override;

void UpdateCursor(PP_CursorType_Dev cursor) override;

void UpdateTickMarks(const std::vector<pp::Rect>& tickmarks) override;

void NotifyNumberOfFindResultsChanged(int total, bool final_result) override;