Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: pdf/pdf_engine.h

Issue 2166193002: Handle ctrl + shift + left click on links in PDF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle ctrl + shift + left click on links in PDF. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pdf/pdf_engine.h
diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h
index 5bba8b9f86061216229b6d582e3f8722ed840e9d..cbe37348ddeb534798b292d609e4afb22dc61849 100644
--- a/pdf/pdf_engine.h
+++ b/pdf/pdf_engine.h
@@ -61,6 +61,15 @@ class PDFEngine {
// The interface that's provided to the rendering engine.
class Client {
public:
+ // JavaScript counterpart of the enum is in navigator.js
+ // and they need to stay in sync.
+ enum class NavigateOption {
+ OPEN_IN_CURRENT_TAB = 0,
+ OPEN_IN_NEW_BACKGROUND_TAB,
+ OPEN_IN_NEW_FOREGROUND_TAB,
+ OPEN_IN_NEW_WINDOW,
+ };
+
virtual ~Client() {}
// Informs the client about the document's size in pixels.
@@ -80,7 +89,7 @@ class PDFEngine {
virtual void ScrollToPage(int page) = 0;
// Navigate to the given url.
- virtual void NavigateTo(const std::string& url, bool open_in_new_tab) = 0;
+ virtual void NavigateTo(const std::string& url, NavigateOption option) = 0;
// Updates the cursor.
virtual void UpdateCursor(PP_CursorType_Dev cursor) = 0;

Powered by Google App Engine
This is Rietveld 408576698