Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: pdf/pdf_engine.h

Issue 2166193002: Handle ctrl + shift + left click on links in PDF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle ctrl + shift + left click on links in PDF. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pdf/pdf_engine.h
diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h
index 5bba8b9f86061216229b6d582e3f8722ed840e9d..3508f20622738808a55f8e7899489eb2a51d0693 100644
--- a/pdf/pdf_engine.h
+++ b/pdf/pdf_engine.h
@@ -27,6 +27,7 @@
#include "ppapi/cpp/size.h"
#include "ppapi/cpp/url_loader.h"
#include "ppapi/cpp/var_array.h"
+#include "ui/base/window_open_disposition.h"
namespace pp {
class InputEvent;
@@ -37,12 +38,6 @@ namespace chrome_pdf {
class Stream;
-#if defined(OS_MACOSX)
-const uint32_t kDefaultKeyModifier = PP_INPUTEVENT_MODIFIER_METAKEY;
-#else // !OS_MACOSX
-const uint32_t kDefaultKeyModifier = PP_INPUTEVENT_MODIFIER_CONTROLKEY;
-#endif // OS_MACOSX
-
// Do one time initialization of the SDK.
bool InitializeSDK();
// Tells the SDK that we're shutting down.
@@ -80,7 +75,8 @@ class PDFEngine {
virtual void ScrollToPage(int page) = 0;
// Navigate to the given url.
- virtual void NavigateTo(const std::string& url, bool open_in_new_tab) = 0;
+ virtual void NavigateTo(const std::string& url,
+ WindowOpenDisposition disposition) = 0;
// Updates the cursor.
virtual void UpdateCursor(PP_CursorType_Dev cursor) = 0;

Powered by Google App Engine
This is Rietveld 408576698