Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pdf/pdf_engine.h

Issue 2166193002: Handle ctrl + shift + left click on links in PDF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/pdf/navigator.js ('K') | « pdf/out_of_process_instance.cc ('k') | pdf/pdfium/pdfium_engine.h » ('j') | pdf/pdfium/pdfium_engine.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdf_engine.h
diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h
index 5bba8b9f86061216229b6d582e3f8722ed840e9d..cba8c40e87fd3002c312cb7c124336c044eee5de 100644
--- a/pdf/pdf_engine.h
+++ b/pdf/pdf_engine.h
@@ -80,7 +80,7 @@ class PDFEngine {
virtual void ScrollToPage(int page) = 0;
// Navigate to the given url.
- virtual void NavigateTo(const std::string& url, bool open_in_new_tab) = 0;
+ virtual void NavigateTo(const std::string& url, int option) = 0;
Lei Zhang 2016/07/21 05:34:28 Can |option| be of type NavigateOption?
jaepark 2016/07/21 22:34:33 Done.
// Updates the cursor.
virtual void UpdateCursor(PP_CursorType_Dev cursor) = 0;
« chrome/browser/resources/pdf/navigator.js ('K') | « pdf/out_of_process_instance.cc ('k') | pdf/pdfium/pdfium_engine.h » ('j') | pdf/pdfium/pdfium_engine.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698