Handle ctrl + shift + left click on links in PDF.

chrome/browser/resources/pdf/navigator.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Creates a new Navigator for navigating to links inside or outside the PDF.
  * @param {string} originalUrl The original page URL.
  * @param {Object} viewport The viewport info of the page.
  * @param {Object} paramsParser The object for URL parsing.
  * @param {Function} navigateInCurrentTabCallback The Callback function that
  *    gets called when navigation happens in the current tab.
- * @param {Function} navigateInNewBackgroundTabCallback The Callback function
- *    that gets called when navigation happens in the new background tab.
+ * @param {Function} navigateInNewTabCallback The Callback function
+ *    that gets called when navigation happens in the new tab.
  */
 function Navigator(originalUrl,
                    viewport,
                    paramsParser,
                    navigateInCurrentTabCallback,
-                   navigateInNewBackgroundTabCallback) {
+                   navigateInNewTabCallback) {
   this.originalUrl_ = originalUrl;
   this.viewport_ = viewport;
   this.paramsParser_ = paramsParser;
   this.navigateInCurrentTabCallback_ = navigateInCurrentTabCallback;
-  this.navigateInNewBackgroundTabCallback_ = navigateInNewBackgroundTabCallback;
+  this.navigateInNewTabCallback_ = navigateInNewTabCallback;
 }
 
+/**
+ * Represents options when navigating to a new url. C++ counterpart of
+ * the enum is in ui/base/window_open_disposition.h. This enum represents
+ * the only values that are passed from Plugin.
+ * @enum {number}
+ */
+Navigator.WindowOpenDisposition = {
+  CURRENT_TAB: 1,
+  NEW_FOREGROUND_TAB: 3,
+  NEW_BACKGROUND_TAB: 4,
+  NEW_WINDOW: 6,
+  SAVE_TO_DISK: 7
+};
+
 Navigator.prototype = {
   /**
    * @private
    * Function to navigate to the given URL. This might involve navigating
    * within the PDF page or opening a new url (in the same tab or a new tab).
    * @param {string} url The URL to navigate to.
    * @param {boolean} newTab Whether to perform the navigation in a new tab or

[Lei Zhang, 2016/07/25 22:10:02]

Doc is out of date.

[jaepark, 2016/07/25 23:24:13]

Done.

    *    in the current tab.
    */
-  navigate: function(url, newTab) {
+  navigate: function(url, disposition) {
     if (url.length == 0)
       return;
 
     // If |urlFragment| starts with '#', then it's for the same URL with a
     // different URL fragment.
     if (url.charAt(0) == '#') {
       // if '#' is already present in |originalUrl| then remove old fragment
       // and add new url fragment.
       var hashIndex = this.originalUrl_.search('#');
       if (hashIndex != -1)
         url = this.originalUrl_.substring(0, hashIndex) + url;
       else
         url = this.originalUrl_ + url;
     }
 
     // If there's no scheme, then take a guess at the scheme.
     if (url.indexOf('://') == -1 && url.indexOf('mailto:') == -1)
       url = this.guessUrlWithoutScheme_(url);
 
     if (!this.isValidUrl_(url))
       return;
 
-    if (newTab) {
-      this.navigateInNewBackgroundTabCallback_(url);
-    } else {
-      this.paramsParser_.getViewportFromUrlParams(
-          url, this.onViewportReceived_.bind(this));
+    switch (disposition) {
+      case Navigator.WindowOpenDisposition.CURRENT_TAB:
+        this.paramsParser_.getViewportFromUrlParams(
+            url, this.onViewportReceived_.bind(this));
+        break;
+      case Navigator.WindowOpenDisposition.NEW_BACKGROUND_TAB:
+        this.navigateInNewTabCallback_(url, false);
+        break;
+      case Navigator.WindowOpenDisposition.NEW_FOREGROUND_TAB:
+        this.navigateInNewTabCallback_(url, true);
+        break;
+      case Navigator.WindowOpenDisposition.NEW_WINDOW:
+        // TODO (jaepark): It should navigate in a new window when

[Lei Zhang, 2016/07/25 22:10:02]

no space after "TODO"

[jaepark, 2016/07/25 23:24:13]

Done.

+        // shift + left clicking link in PDFs. See http://crbug.com/628057.
+        break;

[Lei Zhang, 2016/07/25 22:10:02]

Previously these fell through to SAVE_TO_DISK, which then took the CURRENT_TAB
behavior. The actual behavior was fine, but the way it was written looked a bit
weird. Now these are no-ops, which seem slightly worse than if we at elast open
the link. Can we put paste the CURRENT_TAB code here so these cases at least do
something?

[jaepark, 2016/07/25 23:24:13]

Done.

+      case Navigator.WindowOpenDisposition.SAVE_TO_DISK:
+        // TODO (jaepark) : Alt + left clicking link in PDFs should
+        // donwload the link.
+        break;
+      default:
+        break;
     }
   },
 
   /**
    * @private
    * Called when the viewport position is received.
    * @param {Object} viewportPosition Dictionary containing the viewport
    *    position.
    */
   onViewportReceived_: function(viewportPosition) {
@@ skipping 92 matching lines @@
     if (isRelative) {
       var slashIndex = this.originalUrl_.lastIndexOf('/');
       var path = slashIndex != -1 ?
           this.originalUrl_.substr(0, slashIndex) : this.originalUrl_;
       return path + '/' + url;
     }
 
     return 'http://' + url;
   }
 };