Handle ctrl + shift + left click on links in PDF.

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 1625 matching lines @@
   int page_index = -1;
   int char_index = -1;
   int form_type = FPDF_FORMFIELD_UNKNOWN;
   PDFiumPage::LinkTarget target;
   PDFiumPage::Area area =
       GetCharIndex(event, &page_index, &char_index, &form_type, &target);
 
   // Open link on mouse up for same link for which mouse down happened earlier.
   if (mouse_down_state_.Matches(area, target)) {
     if (area == PDFiumPage::WEBLINK_AREA) {
-      bool open_in_new_tab = !!(event.GetModifiers() & kDefaultKeyModifier) ||
+      NavigateOption option = OPEN_IN_CURRENT_TAB;

[Lei Zhang, 2016/07/21 05:34:28]

No need to initialize since all the cases are covered below. Declare this closer
to when it's used.

[jaepark, 2016/07/21 22:34:33]

Done.

+      bool ctrl = !!(event.GetModifiers() & kDefaultKeyModifier) ||

[Lei Zhang, 2016/07/21 05:34:28]

Maybe control can stay as open_in_new_tab?

[jaepark, 2016/07/21 22:34:33]

Done.

           !!(event.GetModifiers() & PP_INPUTEVENT_MODIFIER_MIDDLEBUTTONDOWN);
-      client_->NavigateTo(target.url, open_in_new_tab);
+
+      bool shift = !!(event.GetModifiers() & PP_INPUTEVENT_MODIFIER_SHIFTKEY);
+
+      if (ctrl) {
+        if (shift)
+          option = OPEN_IN_NEW_FOREGROUND_TAB;
+        else
+          option = OPEN_IN_NEW_BACKGROUND_TAB;
+      } else {
+        if (shift)
+          option = OPEN_IN_NEW_WINDOW;
+        else
+          option = OPEN_IN_CURRENT_TAB;
+      }
+
+      client_->NavigateTo(target.url, option);
       client_->FormTextFieldFocusChange(false);
       return true;
     }
   }
 
   // Prevent middle mouse button from selecting texts.
   if (event.GetButton() == PP_INPUTEVENT_MOUSEBUTTON_MIDDLE)
     return false;
 
   if (page_index != -1) {
@@ skipping 1858 matching lines @@
                                           FPDF_WIDESTRING value,
                                           FPDF_DWORD valueLen,
                                           FPDF_BOOL is_focus) {
   // Do nothing for now.
   // TODO(gene): use this signal to trigger OSK.
 }
 
 void PDFiumEngine::Form_DoURIAction(FPDF_FORMFILLINFO* param,
                                     FPDF_BYTESTRING uri) {
   PDFiumEngine* engine = static_cast<PDFiumEngine*>(param);
-  engine->client_->NavigateTo(std::string(uri), false);
+  engine->client_->NavigateTo(std::string(uri), OPEN_IN_CURRENT_TAB);
 }
 
 void PDFiumEngine::Form_DoGoToAction(FPDF_FORMFILLINFO* param,
                                      int page_index,
                                      int zoom_mode,
                                      float* position_array,
                                      int size_of_array) {
   PDFiumEngine* engine = static_cast<PDFiumEngine*>(param);
   engine->client_->ScrollToPage(page_index);
 }
@@ skipping 370 matching lines @@
   FPDF_DOCUMENT doc =
       FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, nullptr);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf