Fix a Use-after-free bug

Fix a Use-after-free bug

CancelOnFailureAndDeleteSelf() should be the last call
DownloadTargetDeterminer can make.
After that, it is deleted.
Reporting the UMA first, then call CancelOnFailureAndDeleteSelf().

BUG=630370
Committed: https://crrev.com/98fd60a637e0cd2609cb8fb909503bb6cb9b40c6
Cr-Commit-Position: refs/heads/master@{#407585}

[qinmin, 2016-07-21 22:47:49]

qinmin@chromium.org changed reviewers:
+ rdsmith@chromium.org, sky@chromium.org

[qinmin, 2016-07-21 22:47:50]

PTAL, very tiny change

[sky, 2016-07-21 23:03:00]

I'm not a good reviewer for this.

[Randy Smith (Not in Mondays), 2016-07-22 15:39:41]

rdsmith@chromium.org changed reviewers:
+ svaldez@chromium.org
- rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2016-07-22 15:39:42]

Handing over to svaldez@ as I'm going on vacation and already have a backlog of
reviews to catch up.  But I also have a comment :-}.

https://codereview.chromium.org/2166163003/diff/1/chrome/browser/download/dow...
File chrome/browser/download/download_target_determiner.cc (right):

https://codereview.chromium.org/2166163003/diff/1/chrome/browser/download/dow...
chrome/browser/download/download_target_determiner.cc:327:
CancelOnFailureAndDeleteSelf();
Shouldn't you fix this one as well?  (And maybe scan the rest of the file for
examples.)

[qinmin, 2016-07-22 15:54:40]

https://codereview.chromium.org/2166163003/diff/1/chrome/browser/download/dow...
File chrome/browser/download/download_target_determiner.cc (right):

https://codereview.chromium.org/2166163003/diff/1/chrome/browser/download/dow...
chrome/browser/download/download_target_determiner.cc:327:
CancelOnFailureAndDeleteSelf();
On 2016/07/22 15:39:41, Randy Smith - Not in Fridays wrote:
> Shouldn't you fix this one as well?  (And maybe scan the rest of the file for
> examples.)

Good catch, missed it. Fixed

[svaldez, 2016-07-25 15:35:07]

lgtm.

[qinmin, 2016-07-25 19:47:46]

sky@, can you give OWNERs approval? Thx

[sky, 2016-07-25 20:21:34]

Rubber stamp LGTM given Randy signed off on having svaldez review.

[qinmin, 2016-07-25 20:28:49]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-07-25 20:29:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 21:31:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-25 21:33:11]

Description was changed from

==========
Fix a Use-after-free bug

CancelOnFailureAndDeleteSelf() should be the last call
DownloadTargetDeterminer can make.
After that, it is deleted.
Reporting the UMA first, then call CancelOnFailureAndDeleteSelf().

BUG=630370
==========

to

==========
Fix a Use-after-free bug

CancelOnFailureAndDeleteSelf() should be the last call
DownloadTargetDeterminer can make.
After that, it is deleted.
Reporting the UMA first, then call CancelOnFailureAndDeleteSelf().

BUG=630370

Committed: https://crrev.com/98fd60a637e0cd2609cb8fb909503bb6cb9b40c6
Cr-Commit-Position: refs/heads/master@{#407585}
==========

[commit-bot: I haz the power, 2016-07-25 21:33:13]

Patchset 2 (id:??) landed as
https://crrev.com/98fd60a637e0cd2609cb8fb909503bb6cb9b40c6
Cr-Commit-Position: refs/heads/master@{#407585}