arc: bluetooth: Implement socket opening

arc: bluetooth: Implement socket opening

We cannot open BT sockets in side the container due to linux
kernel disallowing socket() calls to BT subsystem in a net
namespace. We avoid this by tunneling the actual socket()
call to outside the container thusly.

BUG=

Committed: https://crrev.com/f6ef3d8451163369bd5c8b0846b68edf75cb0c74
Cr-Commit-Position: refs/heads/master@{#406951}

[dmitrygr, 2016-07-20 23:13:47]

dmitrygr@google.com changed reviewers:
+ lhchavez@chromium.org, rickyz@chromium.org

[Luis Héctor Chávez, 2016-07-20 23:16:38]

https://codereview.chromium.org/2166143002/diff/1/components/arc/bluetooth/ar...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2166143002/diff/1/components/arc/bluetooth/ar...
components/arc/bluetooth/arc_bluetooth_bridge.cc:7: #include <sys/socket.h>
nit: these need to be together with the rest of the system headers (L9-L10) and
sorted lexicographically.

https://codereview.chromium.org/2166143002/diff/1/components/arc/bluetooth/ar...
components/arc/bluetooth/arc_bluetooth_bridge.cc:16: #include
"mojo/edk/embedder/scoped_platform_handle.h"
nit: these need to be together with the rest of the Chromium headers and sorted
lexicographically.

https://codereview.chromium.org/2166143002/diff/1/components/arc/bluetooth/ar...
components/arc/bluetooth/arc_bluetooth_bridge.cc:1032: base::ScopedFD
sock(socket(AF_BLUETOOTH, SOCK_STREAM, BTPROTO_RFCOMM));
nit: can you do

if (!sock.is_valid()) {
  LOG(...);
  callback.Run(mojo::ScopedHandle());
  return;
}

?

[Luis Héctor Chávez, 2016-07-20 23:33:27]

https://codereview.chromium.org/2166143002/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2166143002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:6: #include
<bluetooth/bluetooth.h>
nit: There should be a newline before this

https://codereview.chromium.org/2166143002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:10: 
nit: One newline too many

https://codereview.chromium.org/2166143002/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:1032: base::ScopedFD
sock(socket(AF_BLUETOOTH, SOCK_STREAM, BTPROTO_RFCOMM));
What about the sock.is_valid block?

[Luis Héctor Chávez, 2016-07-20 23:35:56]

lgtm

[dmitrygr, 2016-07-20 23:36:31]

The CQ bit was checked by dmitrygr@google.com to run a CQ dry run

[Luis Héctor Chávez, 2016-07-20 23:36:59]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:37:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 00:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:16:34]

Dry run: This issue passed the CQ dry run.

[rickyz (no longer on Chrome), 2016-07-21 01:17:49]

mojom lgtm

[dmitrygr, 2016-07-21 20:03:29]

The CQ bit was checked by dmitrygr@google.com

[commit-bot: I haz the power, 2016-07-21 20:03:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 21:25:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-21 21:28:01]

Description was changed from

==========
arc: bluetooth: Implement socket opening

We cannot open BT sockets in side the container due to linux
kernel disallowing socket() calls to BT subsystem in a net
namespace. We avoid this by tunneling the actual socket()
call to outside the container thusly.

BUG=
==========

to

==========
arc: bluetooth: Implement socket opening

We cannot open BT sockets in side the container due to linux
kernel disallowing socket() calls to BT subsystem in a net
namespace. We avoid this by tunneling the actual socket()
call to outside the container thusly.

BUG=

Committed: https://crrev.com/f6ef3d8451163369bd5c8b0846b68edf75cb0c74
Cr-Commit-Position: refs/heads/master@{#406951}
==========

[commit-bot: I haz the power, 2016-07-21 21:28:03]

Patchset 4 (id:??) landed as
https://crrev.com/f6ef3d8451163369bd5c8b0846b68edf75cb0c74
Cr-Commit-Position: refs/heads/master@{#406951}