Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 2166123003: [debugger] be more lenient about argument type in %DebugGetProperty. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: test case Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-629996.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug-evaluate.h" 8 #include "src/debug/debug-evaluate.h"
9 #include "src/debug/debug-frames.h" 9 #include "src/debug/debug-frames.h"
10 #include "src/debug/debug-scopes.h" 10 #include "src/debug/debug-scopes.h"
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 401
402 return *isolate->factory()->NewJSArrayWithElements(details); 402 return *isolate->factory()->NewJSArrayWithElements(details);
403 } 403 }
404 404
405 405
406 RUNTIME_FUNCTION(Runtime_DebugGetProperty) { 406 RUNTIME_FUNCTION(Runtime_DebugGetProperty) {
407 HandleScope scope(isolate); 407 HandleScope scope(isolate);
408 408
409 DCHECK(args.length() == 2); 409 DCHECK(args.length() == 2);
410 410
411 CONVERT_ARG_HANDLE_CHECKED(JSObject, obj, 0); 411 CONVERT_ARG_HANDLE_CHECKED(Object, obj, 0);
412 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1); 412 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1);
413 413
414 LookupIterator it(obj, name); 414 LookupIterator it(obj, name);
415 return *DebugGetProperty(&it); 415 return *DebugGetProperty(&it);
416 } 416 }
417 417
418 418
419 // Return the property type calculated from the property details. 419 // Return the property type calculated from the property details.
420 // args[0]: smi with property details. 420 // args[0]: smi with property details.
421 RUNTIME_FUNCTION(Runtime_DebugPropertyTypeFromDetails) { 421 RUNTIME_FUNCTION(Runtime_DebugPropertyTypeFromDetails) {
(...skipping 1393 matching lines...) Expand 10 before | Expand all | Expand 10 after
1815 Handle<Script> script = Handle<Script>(Script::cast(script_val->value())); 1815 Handle<Script> script = Handle<Script>(Script::cast(script_val->value()));
1816 1816
1817 Handle<wasm::WasmDebugInfo> debug_info = 1817 Handle<wasm::WasmDebugInfo> debug_info =
1818 wasm::GetDebugInfo(handle(script->wasm_object(), isolate)); 1818 wasm::GetDebugInfo(handle(script->wasm_object(), isolate));
1819 return *wasm::WasmDebugInfo::DisassembleFunction( 1819 return *wasm::WasmDebugInfo::DisassembleFunction(
1820 debug_info, script->wasm_function_index()); 1820 debug_info, script->wasm_function_index());
1821 } 1821 }
1822 1822
1823 } // namespace internal 1823 } // namespace internal
1824 } // namespace v8 1824 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-629996.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698