Issue 2166123003: [debugger] be more lenient about argument type in %DebugGetProperty.

Issue 2166123003: [debugger] be more lenient about argument type in %DebugGetProperty. (Closed)

Created:
4 years, 5 months ago by Yang

Modified:
4 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[debugger] be more lenient about argument type in %DebugGetProperty. R=mstarzinger@chromium.org BUG=chromium:629996 Committed: https://crrev.com/07a0f9ebff52a5adc25d86ebe4fb893fda2ebef4 Cr-Commit-Position: refs/heads/master@{#37942}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	src/runtime/runtime-debug.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-crbug-629996.js	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 9 (3 generated)

Michael Starzinger

LGTM. Do we have a repro that we could turn into a regression test?

4 years, 5 months ago (2016-07-21 09:09:53 UTC) #2

Yang

On 2016/07/21 09:09:53, Michael Starzinger wrote: > LGTM. Do we have a repro that we ...

4 years, 5 months ago (2016-07-21 11:04:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166123003/20001

4 years, 5 months ago (2016-07-21 11:04:40 UTC) #6

commit-bot: I haz the power

4 years, 5 months ago (2016-07-21 11:29:34 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/07a0f9ebff52a5adc25d86ebe4fb893fda2ebef4
Cr-Commit-Position: refs/heads/master@{#37942}