Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: components/README

Issue 2166093002: Clarify components/README about when to create a component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clarify comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/README
diff --git a/components/README b/components/README
index 8112f6e25d7d1e750c27bd7c4b97482184259af8..199924adbca1a8fb4dae17e542b21022594abaad 100644
--- a/components/README
+++ b/components/README
@@ -1,8 +1,17 @@
-This directory is for features that are intended for reuse across multiple
-embedders (e.g., Android WebView and Chrome).
-
+This directory is for features that are intended for reuse. Example use cases:
+-code that is shared by Chrome on iOS and other Chrome platforms (since the iOS
+ port doesn't use src/chrome)
+-code that is shared between multiple embedders of content (e.g., Android
+ WebView and Chrome)
+-code that is shared between Blink and the browser process (since code in the
+ browser doesn't use Blink, while Blink doesn't include content or chrome to
+ avoid circular dependencies)
+
+In general, if some code is used by a directory "foo" and things above "foo" in
+the dependency tree, the code should probably live in "foo".
+
By default, components can depend only on the lower layers of the Chromium
-codebase(e.g. base/, net/, etc.). Individual components may additionally allow
+codebase (e.g. base/, net/, etc.). Individual components may additionally allow
dependencies on the content API and IPC; however, if such a component is used
by Chrome for iOS (which does not use the content API or IPC), the component
will have to be in the form of a layered component
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698