texture_manager: disable cubemap workaround on ES3

texture_manager: disable cubemap workaround on ES3

This workaround isn't needed in ES3 anymore because the cubemap needs
to be complete before it can be used with glReadPixels. This workaround
also used to trigger an NVIDIA bug that is now a bit more hidden.

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/e4b520cf5f08dba2266e8081b36bee47700eb46a
Cr-Commit-Position: refs/heads/master@{#406681}

[Corentin Wallez, 2016-07-20 20:46:33]

Description was changed from

==========
texture_manager: disable cubemap workaround on ES3

This workaround isn't needed in ES3 anymore because the cubemap needs
to be complete before it can be used with glReadPixels. This workaround
also used to trigger an NVIDIA bug that is now a bit more hidden.

BUG=429053
==========

to

==========
texture_manager: disable cubemap workaround on ES3

This workaround isn't needed in ES3 anymore because the cubemap needs
to be complete before it can be used with glReadPixels. This workaround
also used to trigger an NVIDIA bug that is now a bit more hidden.

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-07-20 20:49:26]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-07-20 20:49:26]

PTAL, this will prevent the last NVIDIA bug from showing up when running the
WebGL CTS. I'll still try to make a minimal-ish repro case for them so that it
can be fixed in a future driver.

Thanks so much Mo for seeing that this workaround isn't needed in ES3!

[Zhenyao Mo, 2016-07-20 20:52:24]

lgtm

Can you combine this with the removal of the test expectation?

[Corentin Wallez, 2016-07-20 20:54:33]

On 2016/07/20 at 20:52:24, zmo wrote:
> lgtm
> 
> Can you combine this with the removal of the test expectation?

Done, thanks!

[Corentin Wallez, 2016-07-20 20:54:37]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-07-20 20:54:37]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2166083002/#ps20001
(title: "texture_manager: disable cubemap workaround on ES3")

[commit-bot: I haz the power, 2016-07-20 20:55:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 21:52:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 21:54:05]

Description was changed from

==========
texture_manager: disable cubemap workaround on ES3

This workaround isn't needed in ES3 anymore because the cubemap needs
to be complete before it can be used with glReadPixels. This workaround
also used to trigger an NVIDIA bug that is now a bit more hidden.

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
texture_manager: disable cubemap workaround on ES3

This workaround isn't needed in ES3 anymore because the cubemap needs
to be complete before it can be used with glReadPixels. This workaround
also used to trigger an NVIDIA bug that is now a bit more hidden.

BUG=429053
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/e4b520cf5f08dba2266e8081b36bee47700eb46a
Cr-Commit-Position: refs/heads/master@{#406681}
==========

[commit-bot: I haz the power, 2016-07-20 21:54:06]

Patchset 2 (id:??) landed as
https://crrev.com/e4b520cf5f08dba2266e8081b36bee47700eb46a
Cr-Commit-Position: refs/heads/master@{#406681}

[Ken Russell (switch to Gerrit), 2016-07-20 23:29:46]

Awesome!!! LGTM++ after the fact.