cc: Compute target space transform dynamically

cc/layers/layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 963 matching lines @@
 
 int Layer::effect_tree_index() const {
   if (!layer_tree_host_ ||
       layer_tree_host_->property_trees()->sequence_number !=
           property_tree_sequence_number_) {
     return -1;
   }
   return effect_tree_index_;
 }
 
+int Layer::render_target_effect_tree_index() const {
+  EffectNode* effect_node =
+      layer_tree_host_->property_trees()->effect_tree.Node(effect_tree_index_);
+  if (effect_node->render_surface)

[ajuma, 2016/07/22 18:29:40]

I think this is always null on the main thread side. So I think this function is
currently always returning the root effect node's id. Did you mean to use
has_render_surface here (on the main thread side it makes sense to do that,
since there's no resourceless software mode to worry about). It also suggests
that the remaining tests that depend on this logic aren't doing interesting
things with surfaces.

[sunxd, 2016/07/22 20:25:03]

Done.

+    return effect_node->id;
+  else
+    return effect_node->target_id;
+}
+
 void Layer::SetScrollTreeIndex(int index) {
   DCHECK(IsPropertyChangeAllowed());
   if (scroll_tree_index_ == index)
     return;
   scroll_tree_index_ = index;
   SetNeedsPushProperties();
 }
 
 int Layer::scroll_tree_index() const {
   if (!layer_tree_host_ ||
@@ skipping 849 matching lines @@
       ->num_copy_requests_in_subtree;
 }
 
 gfx::Transform Layer::screen_space_transform() const {
   DCHECK_NE(transform_tree_index_, -1);
   return draw_property_utils::ScreenSpaceTransform(
       this, layer_tree_host_->property_trees()->transform_tree);
 }
 
 }  // namespace cc