cc: Compute target space transform dynamically

cc/layers/layer_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 142 matching lines @@
 }
 
 void LayerImpl::SetClipTreeIndex(int index) {
   clip_tree_index_ = index;
 }
 
 void LayerImpl::SetEffectTreeIndex(int index) {
   effect_tree_index_ = index;
 }
 
+int LayerImpl::render_target_effect_tree_index() const {
+  EffectNode* effect_node =
+      layer_tree_impl_->property_trees()->effect_tree.Node(effect_tree_index_);
+  if (effect_node->has_render_surface)
+    return effect_node->id;
+  else
+    return effect_node->target_id;
+}
+
 void LayerImpl::SetScrollTreeIndex(int index) {
   scroll_tree_index_ = index;
 }
 
 void LayerImpl::ClearRenderSurfaceLayerList() {
   if (render_surface_)
     render_surface_->ClearLayerLists();
 }
 
 void LayerImpl::PopulateSharedQuadState(SharedQuadState* state) const {
@@ skipping 963 matching lines @@
 gfx::Rect LayerImpl::GetScaledEnclosingRectInTargetSpace(float scale) const {
   gfx::Transform scaled_draw_transform = DrawTransform();
   scaled_draw_transform.Scale(SK_MScalar1 / scale, SK_MScalar1 / scale);
   gfx::Size scaled_bounds = gfx::ScaleToCeiledSize(bounds(), scale);
   return MathUtil::MapEnclosingClippedRect(scaled_draw_transform,
                                            gfx::Rect(scaled_bounds));
 }
 
 RenderSurfaceImpl* LayerImpl::render_target() {
   EffectTree& effect_tree = layer_tree_impl_->property_trees()->effect_tree;
-  EffectNode* node = effect_tree.Node(effect_tree_index_);
-
-  if (node->render_surface)
-    return node->render_surface;
+  EffectNode* effect_node = effect_tree.Node(render_target_effect_tree_index());
+  if (effect_node->render_surface)
+    return effect_node->render_surface;
   else
-    return effect_tree.Node(node->target_id)->render_surface;
+    return effect_tree.Node(effect_node->target_id)->render_surface;
 }
 
 const RenderSurfaceImpl* LayerImpl::render_target() const {
   const EffectTree& effect_tree =
       layer_tree_impl_->property_trees()->effect_tree;
-  const EffectNode* node = effect_tree.Node(effect_tree_index_);
-
-  if (node->render_surface)
-    return node->render_surface;
+  const EffectNode* effect_node =
+      effect_tree.Node(render_target_effect_tree_index());
+  if (effect_node->render_surface)
+    return effect_node->render_surface;
   else
-    return effect_tree.Node(node->target_id)->render_surface;
+    return effect_tree.Node(effect_node->target_id)->render_surface;

[jaydasika, 2016/07/21 22:03:34]

Is this change required ? If target_effect_tree_index() checks render_surface
instead of has_render_surface like in the earlier patch, this won't be required,
right ?

[sunxd, 2016/07/22 14:41:17]

The render_target function is sometimes called before we ever create a render
target, in another word, at this time, effect_node->has_render_surface == true
but effect_node->render_surface == nullptr as we didn't create it.

[ajuma, 2016/07/22 15:05:48]

What's an example of such a callsite? One thing to worry about the way
render_target_effect_tree_index is currently defined is that for resourceless
software mode, non-root effect nodes might have has_render_surface = true even
though they can't have render surfaces (that is, will always have render_surface
== null), so defining render_target_effect_tree_index this way won't return the
effect_tree_index of the actual render target.

[sunxd, 2016/07/22 15:32:14]

I think that's when we cannot render to separate surfaces. Should I define it so
that it returns the root id in this case?

 }
 
 bool LayerImpl::IsHidden() const {
   EffectTree& effect_tree = layer_tree_impl_->property_trees()->effect_tree;
   EffectNode* node = effect_tree.Node(effect_tree_index_);
   return node->screen_space_opacity == 0.f;
 }
 
 bool LayerImpl::InsideReplica() const {
   // There are very few render targets so this should be cheap to do for each
@@ skipping 22 matching lines @@
            .layer_transforms_should_scale_layer_contents) {
     return default_scale;
   }
 
   gfx::Vector2dF transform_scales = MathUtil::ComputeTransform2dScaleComponents(
       ScreenSpaceTransform(), default_scale);
   return std::max(transform_scales.x(), transform_scales.y());
 }
 
 }  // namespace cc