Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 216603003: Fix InstallPhaseEvent so that instances can be passed to script. (Closed)

Created:
6 years, 9 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 9 months ago
Reviewers:
kinuko, haraken
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Fix InstallPhaseEvent so that instances can be passed to script. Events need to provide the V8Event binding their interface name (by overriding Event::interfaceName) and set up wrapper info (by calling ScriptWrappable::init.) Make InstallPhaseEvent follow the rules. BUG=356021 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M Source/modules/serviceworkers/InstallPhaseEvent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/InstallPhaseEvent.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
dominicc (has gone to gerrit)
PTAL ServiceWorker "activate" must pass an InstallPhaseEvent. Without this those events will be wrapped at ...
6 years, 9 months ago (2014-03-28 10:09:55 UTC) #1
haraken
LGTM. We should have some automatic way to detect missing ScriptWrappable::init()...
6 years, 9 months ago (2014-03-28 10:14:39 UTC) #2
kinuko
lgtm
6 years, 9 months ago (2014-03-28 10:22:04 UTC) #3
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 9 months ago (2014-03-28 10:23:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/216603003/1
6 years, 9 months ago (2014-03-28 10:23:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 10:32:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-28 10:32:46 UTC) #7
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 9 months ago (2014-03-28 10:38:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/216603003/1
6 years, 9 months ago (2014-03-28 10:38:32 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 11:03:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 11:03:16 UTC) #11
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 9 months ago (2014-03-28 12:14:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/216603003/1
6 years, 9 months ago (2014-03-28 12:14:18 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 12:54:23 UTC) #14
Message was sent while issue was closed.
Change committed as 170322

Powered by Google App Engine
This is Rietveld 408576698