Cleanup in InstantTab and InstantController

chrome/browser/ui/search/instant_tab.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SEARCH_INSTANT_TAB_H_
 #define CHROME_BROWSER_UI_SEARCH_INSTANT_TAB_H_
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "chrome/browser/ui/search/search_model_observer.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "ui/base/page_transition_types.h"
 
 class GURL;
 
 namespace content {
 class RenderFrameHost;
 class WebContents;
 }
 
 // InstantTab is used to exchange messages with a page that implements the
 // Instant/Embedded Search API (http://dev.chromium.org/embeddedsearch).
 class InstantTab : public content::WebContentsObserver,
-                    public SearchModelObserver {
+                   public SearchModelObserver {
  public:
   // InstantTab calls its delegate in response to messages received from the
   // page. Each method is called with the |contents| corresponding to the page
   // we are observing.
   class Delegate {
    public:
     // Called upon determination of Instant API support. Either in response to
     // the page loading or because we received some other message.
     virtual void InstantSupportDetermined(const content::WebContents* contents,
                                           bool supports_instant) = 0;
 
     // Called when the page is about to navigate to |url|.
     virtual void InstantTabAboutToNavigateMainFrame(
         const content::WebContents* contents,
         const GURL& url) = 0;
 
    protected:
     virtual ~Delegate();
   };
 
-  explicit InstantTab(Delegate* delegate);
+  // Sets |web_contents| as the page to communicate with. |web_contents| may be
+  // NULL, which effectively stops all communication.
+  explicit InstantTab(Delegate* delegate, content::WebContents* web_contents);
 
   ~InstantTab() override;
 
-  // Sets |web_contents| as the page to communicate with. |web_contents| may be
-  // NULL, which effectively stops all communication.
-  void Init(content::WebContents* web_contents);

[Marc Treib, 2016/07/21 16:40:09]

Merged into the ctor, no need for two-phase initialization

-
-  // Returns true if the page is known to support the Instant API. This starts
-  // out false, and is set to true whenever we get any message from the page.
-  // Once true, it never becomes false (the page isn't expected to drop API
-  // support suddenly).
-  bool supports_instant() const;

[Marc Treib, 2016/07/21 16:40:09]

This just forwarded to SearchTabHelper, and the lone caller (InstantController)
can just as well use that directly.

-
-  // Returns true if the page is the local NTP (i.e. its URL is
-  // chrome::kChromeSearchLocalNTPURL).
-  bool IsLocal() const;

[Marc Treib, 2016/07/21 16:40:09]

Not used

-
  private:
   FRIEND_TEST_ALL_PREFIXES(InstantTabTest, IsLocal);
   FRIEND_TEST_ALL_PREFIXES(InstantTabTest,
                            DetermineIfPageSupportsInstant_Local);
   FRIEND_TEST_ALL_PREFIXES(InstantTabTest,
                            DetermineIfPageSupportsInstant_NonLocal);
   FRIEND_TEST_ALL_PREFIXES(InstantTabTest,
                            PageURLDoesntBelongToInstantRenderer);
   FRIEND_TEST_ALL_PREFIXES(InstantTabTest, PageSupportsInstant);
 
@@ skipping 11 matching lines @@
   void InstantSupportDetermined(bool supports_instant);
 
   void ClearContents();
 
   Delegate* const delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(InstantTab);
 };
 
 #endif  // CHROME_BROWSER_UI_SEARCH_INSTANT_TAB_H_