Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py

Issue 2165983003: Revert of Refactor the buildbot module in webkitpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
index c434a3d0837f118a4c477a29a75a7e41d89d4744..704fc4616222a5d97ce12535edc27fd696a2d1d4 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
@@ -4,6 +4,7 @@
import unittest
+from webkitpy.common.net.buildbot_mock import MockBuilder
from webkitpy.common.net.layouttestresults import LayoutTestResults
from webkitpy.common.system.executive_mock import MockExecutive
from webkitpy.common.system.executive_mock import MockExecutive2
@@ -15,7 +16,7 @@
class BaseTestCase(unittest.TestCase):
MOCK_WEB_RESULT = 'MOCK Web result, convert 404 to None=True'
- WEB_PREFIX = 'https://storage.googleapis.com/chromium-layout-test-archives/MOCK_Mac10_11/results/layout-test-results'
+ WEB_PREFIX = 'http://example.com/f/builders/MOCK Mac10.11/results/layout-test-results'
command_constructor = None
@@ -253,7 +254,6 @@
self.options.suffixes = "png,wav,txt"
self.command._rebaseline_test_and_update_expectations(self.options)
- self.maxDiff = None
self.assertItemsEqual(self.tool.web.urls_fetched,
[self.WEB_PREFIX + '/userscripts/another-test-actual.png',
self.WEB_PREFIX + '/userscripts/another-test-actual.wav',
@@ -530,7 +530,7 @@
command_constructor = Rebaseline # AKA webkit-patch rebaseline
def test_rebaseline(self):
- self.command._builders_to_pull_from = lambda: ['MOCK Win7']
+ self.command._builders_to_pull_from = lambda: [MockBuilder('MOCK Win7')]
self._write("userscripts/first-test.html", "test data")
@@ -545,7 +545,7 @@
[['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt,png', '--builder', 'MOCK Win7', '--test', 'userscripts/first-test.html', '--verbose']]])
def test_rebaseline_directory(self):
- self.command._builders_to_pull_from = lambda: ['MOCK Win7']
+ self.command._builders_to_pull_from = lambda: [MockBuilder('MOCK Win7')]
self._write("userscripts/first-test.html", "test data")
self._write("userscripts/second-test.html", "test data")
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698