Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2165983003: Revert of Refactor the buildbot module in webkitpy. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor the buildbot module in webkitpy. (patchset #3 id:40001 of https://codereview.chromium.org/2152663003/ ) Reason for revert: On 2016/07/20 at 17:51:31, vadimsh wrote: > Probably broke rebaseline-o-matic: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/396281 Original issue's description: > Refactor the buildbot module in webkitpy. > > This CL refactors BuildBot so that: > - There is now a results_url method in the BuildBot class (moved from AbstractRebaseliningCommand) > - Redundant functions are removed > - The Builder and Build classes are removed > - Buildbot-related functions in webkitpy.common.config.urls are moved into BuildBot > - Unit test and mock version are updated > > The purpose of this is to simplify the code; this is a follow-up to http://crrev.com/2112133002 which removed some unused functionality. > > Committed: https://crrev.com/66b942da80d7af5806f50630e55a9800102f43e1 > Cr-Commit-Position: refs/heads/master@{#406599} TBR=wkorman@chromium.org,dcampb@google.com,dpranke@chromium.org,vadimsh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b7c2c15eac19863207b008eaaa7916b726ef8d6c Cr-Commit-Position: refs/heads/master@{#406614}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
qyearsley
Created Revert of Refactor the buildbot module in webkitpy.
4 years, 5 months ago (2016-07-20 17:58:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165983003/1
4 years, 5 months ago (2016-07-20 17:59:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 18:03:09 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b7c2c15eac19863207b008eaaa7916b726ef8d6c Cr-Commit-Position: refs/heads/master@{#406614}
4 years, 5 months ago (2016-07-20 18:05:12 UTC) #6
qyearsley
4 years, 5 months ago (2016-07-20 22:06:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2164153002/ by qyearsley@chromium.org.

The reason for reverting is: Creating a re-land CL to fix the issue encountered
in
https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/...
and then re-land.

As of the time when this reland patch is created, I still haven't found the
cause of the problem..

Powered by Google App Engine
This is Rietveld 408576698