DescriptionRevert of Refactor the buildbot module in webkitpy. (patchset #3 id:40001 of https://codereview.chromium.org/2152663003/ )
Reason for revert:
On 2016/07/20 at 17:51:31, vadimsh wrote:
> Probably broke rebaseline-o-matic: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/396281
Original issue's description:
> Refactor the buildbot module in webkitpy.
>
> This CL refactors BuildBot so that:
> - There is now a results_url method in the BuildBot class (moved from AbstractRebaseliningCommand)
> - Redundant functions are removed
> - The Builder and Build classes are removed
> - Buildbot-related functions in webkitpy.common.config.urls are moved into BuildBot
> - Unit test and mock version are updated
>
> The purpose of this is to simplify the code; this is a follow-up to http://crrev.com/2112133002 which removed some unused functionality.
>
> Committed: https://crrev.com/66b942da80d7af5806f50630e55a9800102f43e1
> Cr-Commit-Position: refs/heads/master@{#406599}
TBR=wkorman@chromium.org,dcampb@google.com,dpranke@chromium.org,vadimsh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/b7c2c15eac19863207b008eaaa7916b726ef8d6c
Cr-Commit-Position: refs/heads/master@{#406614}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|