src/interpreter/bytecode-array-builder.cc - Issue 2165953002: [interpreter] Add a register operand to ToNumber

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 2165953002: [interpreter] Add a register operand to ToNumber (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix bytecode graph builder, comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-array-builder.cc

diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc

index 4194e85c2597f0f1eeaf4707f197bc72d6e8305c..04d42551b4b338b56eb85139d99159fcca3dbfec 100644

--- a/src/interpreter/bytecode-array-builder.cc

+++ b/src/interpreter/bytecode-array-builder.cc

@@ -387,8 +387,9 @@ BytecodeArrayBuilder& BytecodeArrayBuilder::CastAccumulatorToName() {

return *this;

}

-BytecodeArrayBuilder& BytecodeArrayBuilder::CastAccumulatorToNumber() {

- Output(Bytecode::kToNumber);

+BytecodeArrayBuilder& BytecodeArrayBuilder::CastAccumulatorToNumber(

+ Register out) {

+ Output(Bytecode::kToNumber, RegisterOperand(out));

return *this;

}