Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: components/syncable_prefs/pref_service_syncable.cc

Issue 2165943002: Fix uninitialized variable in PrefServiceSyncable class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/syncable_prefs/pref_service_syncable.h" 5 #include "components/syncable_prefs/pref_service_syncable.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 17 matching lines...) Expand all
28 const PrefModelAssociatorClient* pref_model_associator_client, 28 const PrefModelAssociatorClient* pref_model_associator_client,
29 base::Callback<void(PersistentPrefStore::PrefReadError)> 29 base::Callback<void(PersistentPrefStore::PrefReadError)>
30 read_error_callback, 30 read_error_callback,
31 bool async) 31 bool async)
32 : PrefService(pref_notifier, 32 : PrefService(pref_notifier,
33 pref_value_store, 33 pref_value_store,
34 user_prefs, 34 user_prefs,
35 pref_registry, 35 pref_registry,
36 read_error_callback, 36 read_error_callback,
37 async), 37 async),
38 pref_service_forked_(false),
38 pref_sync_associator_(pref_model_associator_client, syncer::PREFERENCES), 39 pref_sync_associator_(pref_model_associator_client, syncer::PREFERENCES),
39 priority_pref_sync_associator_(pref_model_associator_client, 40 priority_pref_sync_associator_(pref_model_associator_client,
40 syncer::PRIORITY_PREFERENCES) { 41 syncer::PRIORITY_PREFERENCES) {
41 pref_sync_associator_.SetPrefService(this); 42 pref_sync_associator_.SetPrefService(this);
42 priority_pref_sync_associator_.SetPrefService(this); 43 priority_pref_sync_associator_.SetPrefService(this);
43 44
44 // Let PrefModelAssociators know about changes to preference values. 45 // Let PrefModelAssociators know about changes to preference values.
45 pref_value_store->set_callback(base::Bind( 46 pref_value_store->set_callback(base::Bind(
46 &PrefServiceSyncable::ProcessPrefChange, base::Unretained(this))); 47 &PrefServiceSyncable::ProcessPrefChange, base::Unretained(this)));
47 48
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 FOR_EACH_OBSERVER(PrefServiceSyncableObserver, observer_list_, 183 FOR_EACH_OBSERVER(PrefServiceSyncableObserver, observer_list_,
183 OnIsSyncingChanged()); 184 OnIsSyncingChanged());
184 } 185 }
185 186
186 void PrefServiceSyncable::ProcessPrefChange(const std::string& name) { 187 void PrefServiceSyncable::ProcessPrefChange(const std::string& name) {
187 pref_sync_associator_.ProcessPrefChange(name); 188 pref_sync_associator_.ProcessPrefChange(name);
188 priority_pref_sync_associator_.ProcessPrefChange(name); 189 priority_pref_sync_associator_.ProcessPrefChange(name);
189 } 190 }
190 191
191 } // namespace syncable_prefs 192 } // namespace syncable_prefs
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698