chrome/browser/resources/md_history/side_bar.js - Issue 2165903003: MD History: Show sidebar next to content on wide screens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/side_bar.js

Issue 2165903003: MD History: Show sidebar next to content on wide screens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history_fix_footer_link

Patch Set: calamity@ review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_history/side_bar.html ('k') | chrome/test/data/webui/md_history/history_drawer_test.js » ('j') | chrome/test/data/webui/md_history/history_drawer_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/side_bar.js

diff --git a/chrome/browser/resources/md_history/side_bar.js b/chrome/browser/resources/md_history/side_bar.js

index 8a9c56e43c1fe1d0378929b9d700a0a617628ef1..a47576a2f8fa54c3b4ad91c4ea5617cd0acf9982 100644

--- a/chrome/browser/resources/md_history/side_bar.js

+++ b/chrome/browser/resources/md_history/side_bar.js

@@ -14,14 +14,15 @@ Polymer({

route: Object,

showFooter: Boolean,

- },

- toggle: function() {

- this.$.drawer.toggle();

+ // If true, the sidebar is contained within an app-drawer.

+ drawer: {

+ type: Boolean,

+ reflectToAttribute: true

+ },

- /** @private */

- onDrawerFocus_: function() {

+ focusCurrentPage: function() {

// The desired behavior is for the app-drawer to focus the currently

// selected menu item on opening. However, it will always focus the first

// focusable child. Therefore, we set tabindex=0 on the app-drawer so that

@@ -32,7 +33,7 @@ Polymer({

/** @private */

onSelectorActivate_: function() {

- this.$.drawer.close();

+ this.fire('history-close-drawer');

/**