Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/resources/md_history/history.js

Issue 2165903003: MD History: Show sidebar next to content on wide screens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history_fix_footer_link
Patch Set: dpapad@ review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Send the history query immediately. This allows the query to process during 5 // Send the history query immediately. This allows the query to process during
6 // the initial page startup. 6 // the initial page startup.
7 chrome.send('queryHistory', ['', 0, 0, 0, RESULTS_PER_PAGE]); 7 chrome.send('queryHistory', ['', 0, 0, 0, RESULTS_PER_PAGE]);
8 chrome.send('getForeignSessions'); 8 chrome.send('getForeignSessions');
9 9
10 /** @type {Promise} */ 10 /** @type {Promise} */
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 * a sentence about the existence of other forms of browsing history. 53 * a sentence about the existence of other forms of browsing history.
54 */ 54 */
55 function showNotification( 55 function showNotification(
56 hasSyncedResults, includeOtherFormsOfBrowsingHistory) { 56 hasSyncedResults, includeOtherFormsOfBrowsingHistory) {
57 // TODO(msramek): |hasSyncedResults| was used in the old WebUI to show 57 // TODO(msramek): |hasSyncedResults| was used in the old WebUI to show
58 // the message about other signed-in devices. This message does not exist 58 // the message about other signed-in devices. This message does not exist
59 // in the MD history anymore, so the parameter is not needed. Remove it 59 // in the MD history anymore, so the parameter is not needed. Remove it
60 // when WebUI is removed and this becomes the only client of 60 // when WebUI is removed and this becomes the only client of
61 // BrowsingHistoryHandler. 61 // BrowsingHistoryHandler.
62 waitForAppUpgrade().then(function() { 62 waitForAppUpgrade().then(function() {
63 /** @type {HistoryAppElement} */($('history-app')) 63 /** @type {HistoryAppElement} */ ($('history-app')).showSidebarFooter =
64 .getSideBar().showFooter = includeOtherFormsOfBrowsingHistory; 64 includeOtherFormsOfBrowsingHistory;
65 }); 65 });
66 } 66 }
67 67
68 /** 68 /**
69 * Receives the synced history data. An empty list means that either there are 69 * Receives the synced history data. An empty list means that either there are
70 * no foreign sessions, or tab sync is disabled for this profile. 70 * no foreign sessions, or tab sync is disabled for this profile.
71 * |isTabSyncEnabled| makes it possible to distinguish between the cases. 71 * |isTabSyncEnabled| makes it possible to distinguish between the cases.
72 * 72 *
73 * @param {!Array<!ForeignSession>} sessionList Array of objects describing the 73 * @param {!Array<!ForeignSession>} sessionList Array of objects describing the
74 * sessions from other devices. 74 * sessions from other devices.
(...skipping 15 matching lines...) Expand all
90 /** 90 /**
91 * Called by the history backend after user's sign in state changes. 91 * Called by the history backend after user's sign in state changes.
92 * @param {boolean} isUserSignedIn Whether user is signed in or not now. 92 * @param {boolean} isUserSignedIn Whether user is signed in or not now.
93 */ 93 */
94 function updateSignInState(isUserSignedIn) { 94 function updateSignInState(isUserSignedIn) {
95 waitForAppUpgrade().then(function() { 95 waitForAppUpgrade().then(function() {
96 /** @type {HistoryAppElement} */($('history-app')) 96 /** @type {HistoryAppElement} */($('history-app'))
97 .updateSignInState(isUserSignedIn); 97 .updateSignInState(isUserSignedIn);
98 }); 98 });
99 } 99 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698