Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2165873003: Adds some DCHECKs to help isolate flake (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds some DCHECKs to help isolate flake We seem to be getting messages when a binding is paused. The only way this should be possible is if an associated interface has been created. The added DCHECKs check for this. BUG=626869 TEST=none R=ben@chromium.org Committed: https://crrev.com/3383bb96a7ca62b76c9cc6b119474a023465832b Cr-Commit-Position: refs/heads/master@{#406597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M services/ui/ws/window_tree.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sky
4 years, 5 months ago (2016-07-20 16:20:21 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 5 months ago (2016-07-20 16:46:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165873003/1
4 years, 5 months ago (2016-07-20 16:48:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 17:26:01 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 17:26:09 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:27:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3383bb96a7ca62b76c9cc6b119474a023465832b
Cr-Commit-Position: refs/heads/master@{#406597}

Powered by Google App Engine
This is Rietveld 408576698