Add a toUri method to Resource

Add a toUri method to Resource

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c03b85d418eca9e754f91584418771576f23e348

[Brian Wilkerson, 2016-07-19 21:22:44]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[Brian Wilkerson, 2016-07-19 21:22:45]

This is one of a small handful of changes that will need to be made to finish
getting rid of the Java IO shim classes / methods.

[Paul Berry, 2016-07-19 21:25:57]

On 2016/07/19 21:22:45, Brian Wilkerson wrote:
> This is one of a small handful of changes that will need to be made to finish
> getting rid of the Java IO shim classes / methods.

We should have tests for this new method.

Should this code make use of pkg/analyzer/lib/src/util/fast_uri.dart?

[Brian Wilkerson, 2016-07-20 14:44:39]

PTAL

> We should have tests for this new method.

I don't know how I spaced on that, but I'm glad you didn't. It made me think
about supporting multiple platforms, which was probably broken in the original
version.

> Should this code make use of pkg/analyzer/lib/src/util/fast_uri.dart?

I don't know. The code it will be replacing doesn't use FastUri, and looking at
our code base it appears that FastUri is only being used in a small fraction of
locations. I don't know whether that's necessary or whether we only made changes
in performance critical code, but I think we should *not* use it here until
we've agreed on when to and not to use it.

[scheglov, 2016-07-20 15:25:17]

LGTM

If these URIs are going to be used in hot spots, e.g. sources, we might need to
replace them with FastUri.

[Paul Berry, 2016-07-20 15:25:30]

On 2016/07/20 14:44:39, Brian Wilkerson wrote:
> PTAL
> 
> > We should have tests for this new method.
> 
> I don't know how I spaced on that, but I'm glad you didn't. It made me think
> about supporting multiple platforms, which was probably broken in the original
> version.
> 
> > Should this code make use of pkg/analyzer/lib/src/util/fast_uri.dart?
> 
> I don't know. The code it will be replacing doesn't use FastUri, and looking
at
> our code base it appears that FastUri is only being used in a small fraction
of
> locations. I don't know whether that's necessary or whether we only made
changes
> in performance critical code, but I think we should *not* use it here until
> we've agreed on when to and not to use it.

Fair enough--I just wanted to make sure we weren't going to regress performance.
 I think it's fine to postpone the use of FastUri until profiling results
indicate that it will be of benefit.

[Paul Berry, 2016-07-20 15:25:48]

lgtm

[Brian Wilkerson, 2016-07-20 15:52:28]

Description was changed from

==========
Add a toUri method to Resource
==========

to

==========
Add a toUri method to Resource

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c03b85d418eca9e754f91584418771576f23e348
==========

[Brian Wilkerson, 2016-07-20 15:52:30]

Committed patchset #2 (id:20001) manually as
c03b85d418eca9e754f91584418771576f23e348 (presubmit successful).