third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 2165833006: Merge CSSSVGDocumentValue with CSSURIValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2165833006: Merge CSSSVGDocumentValue with CSSURIValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index 6a5ef8dd3e0efa8398445c3fad36c36a0422aac8..cfe428329ac6a2f0e5a8f27940e824790726e885 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -29,7 +29,6 @@

#include "core/css/CSSPrimitiveValueMappings.h"

#include "core/css/CSSQuadValue.h"

#include "core/css/CSSReflectValue.h"

-#include "core/css/CSSSVGDocumentValue.h"

#include "core/css/CSSShadowValue.h"

#include "core/css/CSSStringValue.h"

#include "core/css/CSSTimingFunctionValue.h"

@@ -1461,7 +1460,7 @@ static CSSValue* consumeFilter(CSSParserTokenRange& range, const CSSParserContex

CSSFunctionValue* filterValue = nullptr;

if (!url.isNull()) {

filterValue = CSSFunctionValue::create(CSSValueUrl);

- filterValue->append(*CSSSVGDocumentValue::create(url));

+ filterValue->append(*CSSURIValue::create(url));

} else {

filterValue = consumeFilterFunction(range, context);

if (!filterValue)