Add sw support to viewer on Linux.

Add sw support to viewer on Linux.

This doesn't yet do anything with srgb/colorspace.

Replaces the --vulkan flag with --backend which takes 'gl', 'vk', or 'sw'.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002

Committed: https://skia.googlesource.com/skia/+/6c471f75b28ba8c7127875277ae27799f57a3ddc

[bsalomon, 2016-07-19 20:54:18]

Description was changed from

==========
Add raster support to viewer on Linux
==========

to

==========
Add raster support to viewer on Linux
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002
==========

[bsalomon, 2016-07-19 20:57:58]

Description was changed from

==========
Add raster support to viewer on Linux
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002
==========

to

==========
Add sw support to viewer on Linux.

This doesn't yet do anything with srgb/colorspace.

Replaces the --vulkan flag with --backend which takes 'gl', 'vk', or 'sw'.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002
==========

[bsalomon, 2016-07-19 20:57:58]

bsalomon@google.com changed reviewers:
+ jvanverth@google.com

[bsalomon, 2016-07-19 21:00:04]

PTAL

[jvanverth1, 2016-07-19 21:18:12]

https://codereview.chromium.org/2165813002/diff/20001/tools/viewer/sk_app/uni...
File tools/viewer/sk_app/unix/RasterWindowContext_unix.h (right):

https://codereview.chromium.org/2165813002/diff/20001/tools/viewer/sk_app/uni...
tools/viewer/sk_app/unix/RasterWindowContext_unix.h:18: static
RasterWindowContext* Create(Display*, ::Window, const DisplayParams&);
If you include Window_unix.h, I typedef Window as XWindow, which might be a
little cleaner than ::Window.

https://codereview.chromium.org/2165813002/diff/20001/tools/viewer/sk_app/uni...
File tools/viewer/sk_app/unix/Window_unix.cpp (right):

https://codereview.chromium.org/2165813002/diff/20001/tools/viewer/sk_app/uni...
tools/viewer/sk_app/unix/Window_unix.cpp:288: fWindowContext =
RasterWindowContext_unix::Create(platformData.fDisplay,
Is there a reason you're using RasterWindowContext_unix::Create rather than
RasterWindowContext::Create?

[bsalomon, 2016-07-25 19:55:54]

This is now rebased on top of https://codereview.chromium.org/2169543002/

https://codereview.chromium.org/2165813002/diff/20001/tools/viewer/sk_app/uni...
File tools/viewer/sk_app/unix/RasterWindowContext_unix.h (right):

https://codereview.chromium.org/2165813002/diff/20001/tools/viewer/sk_app/uni...
tools/viewer/sk_app/unix/RasterWindowContext_unix.h:18: static
RasterWindowContext* Create(Display*, ::Window, const DisplayParams&);
On 2016/07/19 21:18:11, jvanverth1 wrote:
> If you include Window_unix.h, I typedef Window as XWindow, which might be a
> little cleaner than ::Window.

Done.

[bsalomon, 2016-07-26 18:57:27]

Updated this to rebase on top of revisions to
https://codereview.chromium.org/2169543002

[jvanverth1, 2016-07-26 19:11:42]

lgtm

[bsalomon, 2016-07-26 19:13:54]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-07-26 19:14:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:56:34]

Description was changed from

==========
Add sw support to viewer on Linux.

This doesn't yet do anything with srgb/colorspace.

Replaces the --vulkan flag with --backend which takes 'gl', 'vk', or 'sw'.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002
==========

to

==========
Add sw support to viewer on Linux.

This doesn't yet do anything with srgb/colorspace.

Replaces the --vulkan flag with --backend which takes 'gl', 'vk', or 'sw'.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165813002

Committed:
https://skia.googlesource.com/skia/+/6c471f75b28ba8c7127875277ae27799f57a3ddc
==========

[commit-bot: I haz the power, 2016-07-26 19:56:35]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6c471f75b28ba8c7127875277ae27799f57a3ddc