Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2165773002: [Chromecast] Fix crash on keypress in cast_shell with Ozone X11 (Closed)

Created:
4 years, 5 months ago by halliwell
Modified:
4 years, 5 months ago
Reviewers:
kylechar, sadrul
CC:
chromium-reviews, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash on keypress when running cast_shell in Ozone X11 platform BUG=629555 Committed: https://crrev.com/a6fdeeb44c7dfdea50b34e717b3bb304c370f161 Cr-Commit-Position: refs/heads/master@{#406872}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/aura/window_targeter.cc View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (5 generated)
halliwell
I'm not sure if this addresses the root cause of the bug ... but it ...
4 years, 5 months ago (2016-07-19 19:54:30 UTC) #2
sadrul
https://codereview.chromium.org/2165773002/diff/1/ui/aura/window_targeter.cc File ui/aura/window_targeter.cc (right): https://codereview.chromium.org/2165773002/diff/1/ui/aura/window_targeter.cc#newcode111 ui/aura/window_targeter.cc:111: return window; Should this return nullptr?
4 years, 5 months ago (2016-07-20 16:58:36 UTC) #3
halliwell
https://codereview.chromium.org/2165773002/diff/1/ui/aura/window_targeter.cc File ui/aura/window_targeter.cc (right): https://codereview.chromium.org/2165773002/diff/1/ui/aura/window_targeter.cc#newcode111 ui/aura/window_targeter.cc:111: return window; On 2016/07/20 16:58:36, sadrul wrote: > Should ...
4 years, 5 months ago (2016-07-20 17:01:43 UTC) #4
sadrul
ok. lgtm (although, have you considered actually installing a focus-client instead?) Update the CL description ...
4 years, 5 months ago (2016-07-21 14:50:26 UTC) #5
halliwell
On 2016/07/21 14:50:26, sadrul wrote: > ok. lgtm (although, have you considered actually installing a ...
4 years, 5 months ago (2016-07-21 15:33:57 UTC) #7
sadrul
On 2016/07/21 15:33:57, halliwell wrote: > On 2016/07/21 14:50:26, sadrul wrote: > > ok. lgtm ...
4 years, 5 months ago (2016-07-21 15:36:21 UTC) #8
halliwell
On 2016/07/21 15:36:21, sadrul wrote: > On 2016/07/21 15:33:57, halliwell wrote: > > On 2016/07/21 ...
4 years, 5 months ago (2016-07-21 15:45:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165773002/1
4 years, 5 months ago (2016-07-21 15:45:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 16:32:12 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 16:33:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6fdeeb44c7dfdea50b34e717b3bb304c370f161
Cr-Commit-Position: refs/heads/master@{#406872}

Powered by Google App Engine
This is Rietveld 408576698