third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html - Issue 2165763002: Fix layout tests that would fail if ScrollAnchoring was promoted to experimental

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html

Issue 2165763002: Fix layout tests that would fail if ScrollAnchoring was promoted to experimental (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/zoom-body-scroll.html ('k') | third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html b/third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html

index 6816e8cc7fd83742a34634be3f303f33181b6f55..34ddda218ff056a2eb32fcd5f47dc16dd399bb43 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html

@@ -1,52 +1,28 @@

<html>

<head>

-<script>

-function log(str)

- var li = document.createElement("li");

- li.appendChild(document.createTextNode(str));

- var console = document.getElementById("console");

- console.appendChild(li);

-function assertEqual(message, actual, expected)

- if (actual != expected)

- log("\n" + message + ": Failure, actual: " + actual + "; expected: " + expected);

- else

- log("\n" + message + ": Success");

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+</head>

+<body dir="rtl">

-function changeDir(new_dir)

- document.body.dir = new_dir;

- return false;

+<div style="width: 4000px; border: 1px solid red;" id="div">

+Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc et nisl tellus. Vivamus aliquam elit non arcu scelerisque eget dapibus nunc vulputate. Maecenas scelerisque egestas purus, id bibendum magna venenatis vel. Vestibulum bibendum volutpat aliquam. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Vestibulum eget risus sodales mi tristique dignissim et sed lectus. Cras convallis, nibh ut dapibus gravida, enim mauris molestie elit, eget fringilla augue est nec est. Curabitur eu quam non purus sodales pulvinar. Donec ultrices dui eget dolor lobortis in porta quam rutrum. Nulla risus lacus, adipiscing quis ullamcorper vestibulum, condimentum sed lacus. Sed in nunc dolor, quis egestas turpis. Integer arcu tellus, posuere sit amet pellentesque a, molestie at mi. Nulla blandit, mi et euismod imperdiet, augue arcu ornare felis, nec viverra lacus ligula ut metus. Proin ut leo ante, at consectetur sem. Nullam non nunc ligula. Proin sed ante sem, id rutrum purus.

+</div>

-onload = function()

- if (window.testRunner)

- testRunner.dumpAsText();

+<script>

- assertEqual("original scroll x for RTL page ", window.scrollX, 0);

+test(function(t) {

+ assert_equals(window.scrollX, 0, "original scroll x for RTL page");

window.scrollTo(-100, 0);

- assertEqual("horizontal scroll x for RTL page ", window.scrollX, -100);

+ assert_equals(window.scrollX, -100, "horizontal scroll x for RTL page");

document.body.dir = "ltr";

- assertEqual("original scroll x for LTR page ", window.scrollX, 0);

+ assert_greater_than_equal(window.scrollX, 0, "original scroll x for LTR page");

window.scrollTo(100, 0);

- assertEqual("horizontal scroll x for LTR page ", window.scrollX, 100);

+ assert_equals(window.scrollX, 100, "horizontal scroll x for LTR page");

+}, "Test behavior when document.body.dir changes dynamically");

- document.getElementById("div").style.display = "none";

</script>

-</head>

-<body dir="rtl">

-<div style="width: 4000px; border: 1px solid red;" id="div">

-Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc et nisl tellus. Vivamus aliquam elit non arcu scelerisque eget dapibus nunc vulputate. Maecenas scelerisque egestas purus, id bibendum magna venenatis vel. Vestibulum bibendum volutpat aliquam. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Vestibulum eget risus sodales mi tristique dignissim et sed lectus. Cras convallis, nibh ut dapibus gravida, enim mauris molestie elit, eget fringilla augue est nec est. Curabitur eu quam non purus sodales pulvinar. Donec ultrices dui eget dolor lobortis in porta quam rutrum. Nulla risus lacus, adipiscing quis ullamcorper vestibulum, condimentum sed lacus. Sed in nunc dolor, quis egestas turpis. Integer arcu tellus, posuere sit amet pellentesque a, molestie at mi. Nulla blandit, mi et euismod imperdiet, augue arcu ornare felis, nec viverra lacus ligula ut metus. Proin ut leo ante, at consectetur sem. Nullam non nunc ligula. Proin sed ante sem, id rutrum purus.

-</div>

-<ul id="console"></ul>

-<br>

</body>

</html>