third_party/WebKit/LayoutTests/fast/scrolling/scroll-to-origin-with-options-no-layout.html - Issue 2165763002: Fix layout tests that would fail if ScrollAnchoring was promoted to experimental

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/scrolling/scroll-to-origin-with-options-no-layout.html

Issue 2165763002: Fix layout tests that would fail if ScrollAnchoring was promoted to experimental (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/scrolling/scroll-to-origin-no-layout.html ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/same-document-scroll-position-restore.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <div id="spanner"></div>	3 <div id="spanner"></div>

4 <script>	4 <script>

5 var styleCount, layoutCount;	5 var styleCount, layoutCount;

6	6

	7 setPrintTestResultsLazily();

	8

7 function assertSyncLayout(sync) {	9 function assertSyncLayout(sync) {

8 if (window.internals) {	10 if (window.internals) {

9 styleCount = internals.updateStyleAndReturnAffectedElementCount();	11 styleCount = internals.updateStyleAndReturnAffectedElementCount();

10 layoutCount = internals.needsLayoutCount();	12 layoutCount = internals.needsLayoutCount();

11 // scrollTo should have synchronously updated style and layout	13 // scrollTo should have synchronously updated style and layout

12 if (sync) {	14 if (sync) {

13 shouldBe("styleCount", "0");	15 shouldBe("styleCount", "0");

14 shouldBe("layoutCount", "0");	16 shouldBe("layoutCount", "0");

15 } else {	17 } else {

16 shouldNotBe("styleCount", "0");	18 shouldNotBe("styleCount", "0");

(...skipping 22 matching lines...) Expand all Loading...
39 assertSyncLayout(true);	41 assertSyncLayout(true);

40	42

41 spanner.style.height = "2px";	43 spanner.style.height = "2px";

42 scrollTo({ top: 0 });	44 scrollTo({ top: 0 });

43 assertSyncLayout(true);	45 assertSyncLayout(true);

44	46

45 spanner.style.height = "3px";	47 spanner.style.height = "3px";

46 scrollTo({ });	48 scrollTo({ });

47 assertSyncLayout(true);	49 assertSyncLayout(true);

48 </script>	50 </script>

OLD	NEW