third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html - Issue 2165763002: Fix layout tests that would fail if ScrollAnchoring was promoted to experimental

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html

Issue 2165763002: Fix layout tests that would fail if ScrollAnchoring was promoted to experimental (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Undo promoting ScrollAnchoring to test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/css/zoom-body-scroll.html ('K') | « third_party/WebKit/LayoutTests/fast/css/zoom-body-scroll.html ('k') | third_party/WebKit/LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/dom/vertical-scrollbar-when-dir-change.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <html>

2 <head>

3 <script>

4 function log(str)

5 {

6 var li = document.createElement("li");

7 li.appendChild(document.createTextNode(str));

8 var console = document.getElementById("console");

9 console.appendChild(li);

10 }

11

12 function assertEqual(message, actual, expected)

13 {

14 if (actual != expected)

15 log("\n" + message + ": Failure, actual: " + actual + "; expected: " + e xpected);

16 else

17 log("\n" + message + ": Success");

18 }

19

20 function changeDir(new_dir)

21 {

22 document.body.dir = new_dir;

23 return false;

24 }

25

26 onload = function()

27 {

28 if (window.testRunner)

29 testRunner.dumpAsText();

30

31 assertEqual("original scroll x for RTL page ", window.scrollX, 0);

32 window.scrollTo(-100, 0);

33 assertEqual("horizontal scroll x for RTL page ", window.scrollX, -100);

34

35 document.body.dir = "ltr";
ymalik 2016/07/22 16:53:23 @skobes, Changing rtl to ltr causes a layout and w @skobes, Changing rtl to ltr causes a layout and we anchor and adjust, which causes the second half of the expectations to fail. This is probably not a common practice anyway, and what's is testing is covered by https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/dom/... skobes 2016/07/25 20:46:38 This test is intended to check the behavior when d Show quoted text On 2016/07/22 16:53:23, ymalik wrote: > @skobes, Changing rtl to ltr causes a layout and we anchor and adjust, which > causes the second half of the expectations to fail. This is probably not a > common practice anyway, and what's is testing is covered by > https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/dom/... This test is intended to check the behavior when document.body.dir changes dynamically, which horizontal-scrollbar-in-rtl.html doesn't cover. It looks like both of them were added in http://crrev.com/ef39f97 which introduced the "scroll origin" concept to FrameView. Maybe just check for scrollX >= 0 on the next line, instead of == 0? ymalik 2016/07/26 21:03:50 Thanks. Done. Show quoted text On 2016/07/25 20:46:38, skobes wrote: > On 2016/07/22 16:53:23, ymalik wrote: > > @skobes, Changing rtl to ltr causes a layout and we anchor and adjust, which > > causes the second half of the expectations to fail. This is probably not a > > common practice anyway, and what's is testing is covered by > > > https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/dom/... > > This test is intended to check the behavior when document.body.dir changes > dynamically, which horizontal-scrollbar-in-rtl.html doesn't cover. It looks > like both of them were added in http://crrev.com/ef39f97 which introduced the > "scroll origin" concept to FrameView. > > Maybe just check for scrollX >= 0 on the next line, instead of == 0? Thanks. Done.
36 assertEqual("original scroll x for LTR page ", window.scrollX, 0);

37 window.scrollTo(100, 0);

38 assertEqual("horizontal scroll x for LTR page ", window.scrollX, 100);

39

40 document.getElementById("div").style.display = "none";

41 }

42 </script>

43 </head>

44 <body dir="rtl">

45

46 <div style="width: 4000px; border: 1px solid red;" id="div">

47 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc et nisl tellus. Vi vamus aliquam elit non arcu scelerisque eget dapibus nunc vulputate. Maecenas sc elerisque egestas purus, id bibendum magna venenatis vel. Vestibulum bibendum vo lutpat aliquam. Cum sociis natoque penatibus et magnis dis parturient montes, na scetur ridiculus mus. Vestibulum eget risus sodales mi tristique dignissim et se d lectus. Cras convallis, nibh ut dapibus gravida, enim mauris molestie elit, eg et fringilla augue est nec est. Curabitur eu quam non purus sodales pulvinar. Do nec ultrices dui eget dolor lobortis in porta quam rutrum. Nulla risus lacus, ad ipiscing quis ullamcorper vestibulum, condimentum sed lacus. Sed in nunc dolor, quis egestas turpis. Integer arcu tellus, posuere sit amet pellentesque a, moles tie at mi. Nulla blandit, mi et euismod imperdiet, augue arcu ornare felis, nec viverra lacus ligula ut metus. Proin ut leo ante, at consectetur sem. Nullam non nunc ligula. Proin sed ante sem, id rutrum purus.

48 </div>

49 <ul id="console"></ul>

50 <br>

51 </body>

52 </html>

OLD	NEW