Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: apps/app_window_browsertest.cc

Issue 216573002: Minor cleanup of app_window_browsertest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/app_window_browsertest.cc
diff --git a/apps/app_window_browsertest.cc b/apps/app_window_browsertest.cc
index cc411551ceb908cf440f5a0f220ffb49b677b6af..228e92c7b696433c65cf03fd984924d4268708a6 100644
--- a/apps/app_window_browsertest.cc
+++ b/apps/app_window_browsertest.cc
@@ -20,7 +20,7 @@ typedef extensions::PlatformAppBrowserTest AppWindowBrowserTest;
#endif
// Verifies that the NativeAppWindows implement GetFrameInsets() correctly.
-// See crbug.com/346115
+// See http://crbug.com/346115
IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) {
AppWindow* app_window = CreateTestAppWindow("{}");
NativeAppWindow* native_window = app_window->GetBaseWindow();
@@ -28,7 +28,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) {
// It is a reasonable assumption that the top padding must be greater than
// the bottom padding due to the title bar.
- EXPECT_TRUE(insets.top() > insets.bottom());
+ EXPECT_GT(insets.top(), insets.bottom());
CloseAppWindow(app_window);
}
@@ -40,7 +40,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) {
#endif
// Verifies that the NativeAppWindows implement GetFrameInsets() correctly.
-// See crbug.com/346115
+// See http://crbug.com/346115
IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForColoredFrame) {
AppWindow* app_window =
CreateTestAppWindow("{ \"frame\": { \"color\": \"#ffffff\" } }");
@@ -49,7 +49,7 @@ IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForColoredFrame) {
// It is a reasonable assumption that the top padding must be greater than
// the bottom padding due to the title bar.
- EXPECT_TRUE(insets.top() > insets.bottom());
+ EXPECT_GT(insets.top(), insets.bottom());
CloseAppWindow(app_window);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698