Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 216573002: Minor cleanup of app_window_browsertest. (Closed)

Created:
6 years, 9 months ago by Matt Giuca
Modified:
6 years, 8 months ago
Reviewers:
tmdiep, benwells
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Minor cleanup of app_window_browsertest. Use EXPECT_GT instead of EXPECT_TRUE. Made URLs clickable. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M apps/app_window_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Matt Giuca
Very minor but it didn't fit in my other CL. (Not urgent.) tmdiep: Author. benwells: ...
6 years, 9 months ago (2014-03-28 07:32:14 UTC) #1
tmdiep
On 2014/03/28 07:32:14, Matt Giuca wrote: > Very minor but it didn't fit in my ...
6 years, 9 months ago (2014-03-28 09:42:32 UTC) #2
benwells
lgtm
6 years, 8 months ago (2014-03-30 22:54:41 UTC) #3
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 8 months ago (2014-03-30 22:54:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/216573002/1
6 years, 8 months ago (2014-03-30 22:55:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 23:29:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-03-30 23:29:39 UTC) #7
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 8 months ago (2014-03-31 00:41:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/216573002/1
6 years, 8 months ago (2014-03-31 00:41:05 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 01:57:57 UTC) #10
Message was sent while issue was closed.
Change committed as 260481

Powered by Google App Engine
This is Rietveld 408576698