Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2165713002: Change the error message in WebCrypto when using a key that has BOTH (Closed)

Created:
4 years, 5 months ago by eroman
Modified:
4 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the error message in WebCrypto when using a key that has BOTH the wrong algorithm name AND usages. BUG=628423 Committed: https://crrev.com/3619ed60b052c505736abc9cf601c08199189883 Cr-Commit-Position: refs/heads/master@{#406347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/wrong-key-class.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/wrong-key-class-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/rsa-oaep/key-manipulation.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/rsa-oaep/key-manipulation-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/CryptoKey.cpp View 1 chunk +18 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
eroman
4 years, 5 months ago (2016-07-19 17:40:35 UTC) #3
Ryan Sleevi
lgtm
4 years, 5 months ago (2016-07-19 17:43:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165713002/1
4 years, 5 months ago (2016-07-19 19:13:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 19:24:38 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 19:27:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3619ed60b052c505736abc9cf601c08199189883
Cr-Commit-Position: refs/heads/master@{#406347}

Powered by Google App Engine
This is Rietveld 408576698