Make sk_app::WindowContext directly create a SkSurface without an intermediate GrRenderTarget

tools/viewer/sk_app/WindowContext.h

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef WindowContext_DEFINED
 #define WindowContext_DEFINED
 
 #include "DisplayParams.h"
@@ skipping 27 matching lines @@
 
     SkSurfaceProps getSurfaceProps() const { return fSurfaceProps; }
     void setSurfaceProps(const SkSurfaceProps& props) {
         fSurfaceProps = props;
     }
 
     virtual GrBackendContext getBackendContext() = 0;
     GrContext* getGrContext() const { return fContext; }
 
     sk_sp<SkSurface> createOffscreenSurface(bool sRGB);
-    sk_sp<SkSurface> createRenderSurface(sk_sp<GrRenderTarget>, int colorBits);
     void presentRenderSurface(sk_sp<SkSurface> renderSurface, sk_sp<GrRenderTarget> rt,
                               int colorBits);
 
 protected:
     virtual bool isGpuContext() { return true;  }
 
+    sk_sp<SkSurface> createRenderSurface(GrBackendRenderTargetDesc, int colorBits);

[Brian Osman, 2016/07/19 16:08:18]

Pass the desc by const& in both places? (Why is it passed by value here, and by
pointer later?)

[bsalomon, 2016/07/19 16:19:17]

It's required for this function and optional for the other (there is no desc
when createSurface is called from createOffscreenSurface).

+
     GrContext*        fContext;
 
     int               fWidth;
     int               fHeight;
     DisplayParams     fDisplayParams;
     GrPixelConfig     fPixelConfig;
     SkSurfaceProps    fSurfaceProps;
 
 private:
     sk_sp<SkSurface> createSurface(
-            sk_sp<GrRenderTarget>, int colorBits, bool offscreen, bool forceSRGB);
+            GrBackendRenderTargetDesc*, int colorBits, bool offscreen, bool forceSRGB);
 };
 
 }   // namespace sk_app
 
 #endif