chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc - Issue 2165693002: Fix tests in when MD is set to EXPERIMENTAL by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

Issue 2165693002: Fix tests in when MD is set to EXPERIMENTAL by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/workspace/workspace_window_resizer_unittest.cc ('K') | « ash/wm/workspace_controller_unittest.cc ('k') | chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc » ('j') | chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

index a03a3816582a55cad43661f9f2ef8df951b86dce..d2720b627aa5b651990848f3a279d9e4be05c45e 100644

--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

@@ -247,6 +247,9 @@ void BrowserNonClientFrameViewAsh::ResetWindowControls() {

// Hide the caption buttons in immersive fullscreen when the tab light bar

// is visible because it's confusing when the user hovers or clicks in the

// top-right of the screen and hits one.

+ // TODO(yiyix): Update caption_button_container_'s visibility when Chrome OS

msw 2016/07/20 20:06:50 nit: |caption_button_container_|'s

msw 2016/07/20 20:06:50 q: Could you add MD-specific behavior now and avoi

yiyix 2016/07/21 18:32:35 Done.

yiyix 2016/07/21 18:32:35 As we have discussed offline, there is no behavior

+ // MD is enabled by default because it is currently dependent on

+ // |use_tab_indicators_| which is deprecated in MD.

caption_button_container_->SetVisible(!UseImmersiveLightbarHeaderStyle());

caption_button_container_->ResetWindowControls();

}