Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Side by Side Diff: base/threading/thread_checker_impl.h

Issue 2165663003: TaskScheduler: Add SequenceToken and ScopedSetSequenceTokenForCurrentThread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improve comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_THREADING_THREAD_CHECKER_IMPL_H_ 5 #ifndef BASE_THREADING_THREAD_CHECKER_IMPL_H_
6 #define BASE_THREADING_THREAD_CHECKER_IMPL_H_ 6 #define BASE_THREADING_THREAD_CHECKER_IMPL_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/sequence_token.h"
10 #include "base/synchronization/lock.h" 11 #include "base/synchronization/lock.h"
11 #include "base/threading/platform_thread.h" 12 #include "base/threading/platform_thread.h"
12 13
13 namespace base { 14 namespace base {
14 15
15 // Real implementation of ThreadChecker, for use in debug mode, or 16 // Real implementation of ThreadChecker, for use in debug mode, or for temporary
16 // for temporary use in release mode (e.g. to CHECK on a threading issue 17 // use in release mode (e.g. to CHECK on a threading issue seen only in the
17 // seen only in the wild). 18 // wild).
18 // 19 //
19 // Note: You should almost always use the ThreadChecker class to get the 20 // Note: You should almost always use the ThreadChecker class to get the right
20 // right version for your build configuration. 21 // version for your build configuration.
21 class BASE_EXPORT ThreadCheckerImpl { 22 class BASE_EXPORT ThreadCheckerImpl {
22 public: 23 public:
23 ThreadCheckerImpl(); 24 ThreadCheckerImpl();
24 ~ThreadCheckerImpl(); 25 ~ThreadCheckerImpl();
25 26
26 bool CalledOnValidThread() const WARN_UNUSED_RESULT; 27 bool CalledOnValidThread() const WARN_UNUSED_RESULT;
27 28
28 // Changes the thread that is checked for in CalledOnValidThread. This may 29 // Changes the thread that is checked for in CalledOnValidThread. This may
29 // be useful when an object may be created on one thread and then used 30 // be useful when an object may be created on one thread and then used
30 // exclusively on another thread. 31 // exclusively on another thread.
31 void DetachFromThread(); 32 void DetachFromThread();
32 33
33 private: 34 private:
34 void EnsureThreadIdAssigned() const; 35 void EnsureAssigned() const;
35 36
37 // Members are mutable so that CalledOnValidThread() can set them.
38
39 // Synchronizes access to all members.
36 mutable base::Lock lock_; 40 mutable base::Lock lock_;
37 // This is mutable so that CalledOnValidThread can set it. 41
38 // It's guarded by |lock_|. 42 // Thread on which CalledOnValidThread() may return true.
39 mutable PlatformThreadRef valid_thread_id_; 43 mutable PlatformThreadRef thread_id_;
44
45 // SequenceToken for which CalledOnValidThread() may return true. Used to
46 // ensure that CalledOnValidThread() doesn't return true for TaskScheduler
47 // tasks that happen to run on the same thread but weren't posted to the same
48 // SingleThreadTaskRunner.
49 mutable internal::SequenceToken sequence_token_;
40 }; 50 };
41 51
42 } // namespace base 52 } // namespace base
43 53
44 #endif // BASE_THREADING_THREAD_CHECKER_IMPL_H_ 54 #endif // BASE_THREADING_THREAD_CHECKER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698