Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2165643002:
Add more error regexps for git retry (Closed)
|
Created:
4 years, 5 months ago by Sergey Belov Modified:
4 years, 5 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionAdd more error regexps for git retry
BUG=
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a2148c42a127afc1f8ffc6b2532f70121578cf
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add more error regexps for git retry #Messages
Total messages: 30 (14 generated)
Description was changed from ========== Add more error regexps for git retry BUG= ========== to ========== Add more error regexps for git retry BUG= ==========
maruel@chromium.org changed reviewers: + dnj@chromium.org
- Added dnj@chromium as reviewer - Sergey, please use your corp email address. - Sergey, you need to click "Publish" for an email to be sent.
dnj@google.com changed reviewers: + dnj@google.com
https://codereview.chromium.org/2165643002/diff/1/git_common.py File git_common.py (right): https://codereview.chromium.org/2165643002/diff/1/git_common.py#newcode102 git_common.py:102: r'fatal: bad object' I'm not sure that this is retriable. Couldn't this indicate a corrupt local repository?
On 2016/07/19 15:38:15, dnj (Google) wrote: > https://codereview.chromium.org/2165643002/diff/1/git_common.py > File git_common.py (right): > > https://codereview.chromium.org/2165643002/diff/1/git_common.py#newcode102 > git_common.py:102: r'fatal: bad object' > I'm not sure that this is retriable. Couldn't this indicate a corrupt local > repository? It could be corrupted because of bad network connection. That was our case at least.
Also, before we can accept this change, please sign the CLA at: https://cla.developers.google.com/clas https://codereview.chromium.org/2165643002/diff/1/git_common.py File git_common.py (right): https://codereview.chromium.org/2165643002/diff/1/git_common.py#newcode102 git_common.py:102: r'fatal: bad object' On 2016/07/19 15:38:15, dnj (Google) wrote: > I'm not sure that this is retriable. Couldn't this indicate a corrupt local > repository? (Please reply to comments inline, makes it easier to track) After some research, this error can happen for any number of reasons, and has been known to happen during remote and local operations. Because this is potentially caused by local failure, it's best to leave it out of "git retry", which needs to only handle transient errors.
Updated patchset, signed CLA
The CQ bit was checked by arikon@gmail.com
The CQ bit was unchecked by arikon@gmail.com
The CQ bit was unchecked by arikon@gmail.com
dnj@google.com changed reviewers: + arikon@gmail.com - Arikon@gmail.com
Thanks, lgtm
The CQ bit was checked by arikon@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
On 2016/07/20 16:10:57, dnj (Google) wrote: > Thanks, lgtm How and when it will be merged?
The CQ bit was checked by dnj@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
nodir@chromium.org changed reviewers: + nodir@chromium.org
lgtm
The CQ bit was checked by dnj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add more error regexps for git retry BUG= ========== to ========== Add more error regexps for git retry BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a2148c42a127... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a2148c42a127... |
